Project

General

Profile

Actions
Copy link

Defect #35017

closed

X-Redmine-Issue-Assignee email header field is empty when the assignee of an issue is a group

Added by Akihiro MATOBA over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Email notifications
Target version:
5.0.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

When I assign an issue to a group, the X-Redmine-Issue-Assignee: header in the notification mail is empty.

As is:

X-Redmine-Issue-Assignee:

Should be:
X-Redmine-Issue-Assignee: Group (A Team)

Files

Download all files
35017_v1.patch (2.97 KB) 35017_v1.patch Akihiro MATOBA, 2021-04-03 12:54
35017_v2.patch (3.06 KB) 35017_v2.patch Go MAEDA, 2021-05-16 08:53

Related issues

Related to Redmine - Feature #19939: New X-Redmine-Issue-Priority header, and modification of X-Redmine-Issue-AssigneeNew

Actions
Actions
Copy link
 #2

Updated by Mizuki ISHIKAWA over 2 years ago

I reviewed the patch. LGTM.

Actions
Copy link
 #3

Updated by Go MAEDA over 2 years ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Go MAEDA over 2 years ago

  • Target version set to Candidate for next major release

I think the suggested format (X-Redmine-Issue-Assignee: Group (A Team)) is well considered.

  • If the group name is simply set to X-Redmine-Issue-Assignee, it may conflict with a user’s login, but the proposed format avoids that problem
  • The keyword "Group" never conflicts with a user's login because the first letter is uppercase
  • If in the future we want to extend X-Redmine-Issue-Assignee to include the display name of the user, we can use the same format like "admin (Redmine Admin)"
Actions
Copy link
 #5

Updated by Go MAEDA over 2 years ago

  • Tracker changed from Patch to Defect
  • Subject changed from "X-Redmine-Issue-Assignee:" header should contain a group name, not empty to X-Redmine-Issue-Assignee header in email notifications is empty when the assignee is a group
Actions
Copy link
 #6

Updated by Go MAEDA over 2 years ago

  • Target version changed from Candidate for next major release to 5.0.0

Setting the target version to 5.0.0.

Actions
Copy link
 #7

Updated by Go MAEDA over 2 years ago

Updated the patch. I unified the same code written twice.

Actions
Copy link
 #8

Updated by Go MAEDA over 2 years ago

  • Related to Feature #19939: New X-Redmine-Issue-Priority header, and modification of X-Redmine-Issue-Assignee added
Actions
Copy link
 #9

Updated by Go MAEDA over 2 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch.

Now the value of X-Redmine-Issue-Assignee email header field is "Group (#{issue.assigned_to.name})" (example: "Group (A Team)") if the assignee of an issue is a group.

Thank you for your contribution.

Actions
Copy link
 #10

Updated by Go MAEDA over 2 years ago

  • Subject changed from X-Redmine-Issue-Assignee header in email notifications is empty when the assignee is a group to X-Redmine-Issue-Assignee email header field is empty when the assignee of an issue is a group
Actions
Copy link

Also available in: Atom PDF