Patch #35215
closed
Don't display "No Match Found!" when the inline autocomplete doesn't return any result
0%
Description
Hello there,
it would be very helpful if we would be able to change the "No Match Found!" message that is included via the third party library tribute.js. I could hardcode it into the file itself, but that just seems odd.
Best regards
Files
Updated by Takashi Kato over 3 years ago
- File patch1.diff patch1.diff added
In the "tribute.js", the "noMatchTemplate" property for each entry in the "collection" is ineffective. (README is confusing. I raise an issue if I can.) The "noMatchTemplate" specified separately from the "collection" is effective.
An empty string is effective if not want to display a message when there is no match. No function is needed. (again, README is confusing.)
Updated by Marius BĂLTEANU almost 3 years ago
- Target version set to Candidate for next minor release
I think it's better to not show any message as Takashi Kato proposes.
Updated by Marius BĂLTEANU almost 3 years ago
- Tracker changed from Feature to Patch
- Subject changed from tribute.js third party library localization to Don't display "No Match Found!" when the inline autocomplete doesn't return any result
- Category set to UI
- Status changed from New to Closed
- Target version changed from Candidate for next minor release to 4.2.4
Patch committed, thanks!
I didn't merge it to 4.1-stable because of the conflicts.