Project

General

Profile

Actions

Feature #35365

closed

Allow sending account information when importing users

Added by Go MAEDA over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Importers
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

Currently, the user import feature (#33102) does not have a feature to send account information to newly created users. Since there is a "Send account information to the user" checkbox when adding users one by one from the web UI, I think there should be the same kind of feature for importing from CSV.

The "Import users" screen already has a "Send email notifications during the import" checkbox (#22771, currently not working when importing users). I think it would be better if the account information is sent when this checkbox is turned on.


Files

35365.patch (1.45 KB) 35365.patch Yuichi HARADA, 2021-06-15 08:58
Actions #1

Updated by Yuichi HARADA over 2 years ago

Go MAEDA wrote:

The "Import users" screen already has a "Send email notifications during the import" checkbox (#22771, currently not working when importing users). I think it would be better if the account information is sent when this checkbox is turned on.

+1
"Send email notifications during the import" checkbox didn't work, but it works with the following patch.

diff --git a/app/models/user_import.rb b/app/models/user_import.rb
index 71407c14e..609c9b078 100644
--- a/app/models/user_import.rb
+++ b/app/models/user_import.rb
@@ -115,4 +115,8 @@ class UserImport < Import
     object.send(:safe_attributes=, attributes, user)
     object
   end
+
+  def extend_object(row, item, object)
+    Mailer.deliver_account_information(object, object.password) if yes?(settings['notifications'])
+  end
 end
Actions #2

Updated by Go MAEDA over 2 years ago

  • Target version set to Candidate for next major release
Actions #3

Updated by Go MAEDA over 2 years ago

  • Target version changed from Candidate for next major release to 5.0.0

Setting the target version to 5.0.0.

Actions #4

Updated by Go MAEDA over 2 years ago

  • Subject changed from Allow sending account information to the user when importing users to Allow sending account information when importing users
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for your contribution.

Now you can send account information if you check the "Send email notifications during the import" checkbox on the user import dialog.

Actions

Also available in: Atom PDF