Patch #35396

Use base_scope for issue query results

Added by Alexander Meindl 3 months ago. Updated 3 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:5.0.0

Description

This is some refactoring, which drops redundant definition of query scope. With this change, base_scope is used for issues.

Second advantage is, plugin developer can overwrite base_scope to include more features (e.g. for search filter).

There are no downsides with it.

issues_with_base_scope.patch Magnifier (550 Bytes) Alexander Meindl, 2021-06-10 18:59

issues_with_base_scope_v2.patch Magnifier (938 Bytes) Alexander Meindl, 2021-06-10 19:06

Associated revisions

Revision 21040
Added by Go MAEDA 3 months ago

Use base_scope for issue query results (#35396).

Patch by Alexander Meindl.

History

#1 Updated by Alexander Meindl 3 months ago

I created a second patch, which also uses base_scope for issue_ids.

#2 Updated by Go MAEDA 3 months ago

  • Category changed from Issues list to Code cleanup/refactoring
  • Target version set to Candidate for next major release

IssueQuery#base_scope was added in r14642. I think the proposed changes should have been included in r14642.

#3 Updated by Go MAEDA 3 months ago

  • Target version changed from Candidate for next major release to 5.0.0

Setting the target version to 5.0.0.

#4 Updated by Go MAEDA 3 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you.

Also available in: Atom PDF