Project

General

Profile

Actions

Defect #35539

closed

Race condition (possible filename collision) in Attachment.disk_filename

Added by Jens Krämer over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Attachments
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Affected version:

Description

When two (or more) files with the same name are uploaded at the same time, it may happen that two or more of the resulting attachment records end up using the same disk file, resulting in data loss if the files actually differ in content. This was already previously mentioned in #34479-2 (but was unrelated to that issue and hence got "lost")

The problem is that Attachment.disk_filename finds a non-existant filename, but fails to "claim" this name in the file system while doing so. So nothing stops a parallel process to end up using the same name if it tries to do so before the first process actually creates the file.

This patch, extracted from Planio , instead tries to create a file directly, with the File::EXCL flag set, catches the error which means 'filename taken already' and retries until the file is created. This way, filenames are guaranteed to be unique by the underlying file system.


Files


Related issues

Related to Redmine - Patch #35720: Defect: Binmode specified twiceClosedGo MAEDA

Actions
Related to Redmine - Patch #35721: Unlink files after they're closedClosed

Actions
Actions #1

Updated by Go MAEDA over 2 years ago

  • Target version set to Candidate for next major release
Actions #2

Updated by Go MAEDA over 2 years ago

  • Target version changed from Candidate for next major release to 5.0.0

Setting the target version to 5.0.0.

Actions #3

Updated by Go MAEDA over 2 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you.

Actions #4

Updated by Go MAEDA over 2 years ago

  • Related to Patch #35720: Defect: Binmode specified twice added
Actions #5

Updated by Go MAEDA over 2 years ago

  • Related to Patch #35721: Unlink files after they're closed added
Actions #6

Updated by Go MAEDA over 2 years ago

  • Status changed from Closed to Reopened

Reopening this issue in order to handle #35720 and #35721.

Actions #7

Updated by Go MAEDA over 2 years ago

  • Status changed from Reopened to Closed

Go MAEDA wrote:

Reopening this issue in order to handle #35720 and #35721.

Committed the fixes in r21193 and r21194.

Actions #8

Updated by Go MAEDA about 2 years ago

  • Tracker changed from Patch to Defect
Actions

Also available in: Atom PDF