Feature #35742
Enable task list items for CommonMark text formatting
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Marius BALTEANU | % Done: | 0% | |
| Category: | Text formatting | |||
| Target version: | 5.0.0 | |||
| Resolution: | Fixed |
Description
The task list extensions will be a very nice addition for Common Mark text formatting.
Screenshot_2021-10-09_at_17-25-08.png (10.8 KB)
0001-Enable-task-list-for-CommonMark-Markdown-formater-35.patch 
(3.47 KB)
0002-Adds-task-list-button-to-toolbar-for-CommonMark-form.patch
(2.49 KB)
0003-Updates-help-file-for-common_mark-to-include-the-tas.patch
(1.75 KB)
bt_tl.png (479 Bytes)
Related issues
Associated revisions
Enable task list items for Common Mark text formatting (#35742).
Fix path to task list items icon (#35742).
Updates en help file for common_mark to include the task list items feature (#35742).
History
#1
Updated by Marius BALTEANU 10 months ago
- Related to Feature #32424: CommonMark Markdown Text Formatting added
#2
Updated by Marius BALTEANU 10 months ago
- File 0001-Enable-task-list-for-CommonMark-Markdown-formater-35.patch added
I'm adding a patch for testing purposes, I still need to:
- Add tests
- Add an icon to JS toolbar
- Allow clicking task item checkboxes directly.
- Try to add this to Textile
From my point of view, the feature is useful enough only with the first 2 items and we can improve later with 3 and 4. What do you think?
Regarding the tech side, I tried to implement it using only the tasklist extension provided by the CommonMark, but it requires to whitelist in the sanitize the following tags: ul, li, input type="checkbox". Also, using this extensions it will make harder to port this feature to textile.
#3
Updated by Marius BALTEANU 8 months ago
- Target version set to 5.0.0
I think we should deliver this along with the new CommonMark formatter. Any feedback is appreciated.
#4
Updated by Go MAEDA 8 months ago
- File Screenshot_2021-10-09_at_17-25-08.png added
Really nice feature. This should be delivered in Redmine 5.0.0.
Marius BALTEANU wrote:
I'm adding a patch for testing purposes, I still need to:
- Add tests
- Add an icon to JS toolbar
- Allow clicking task item checkboxes directly.
- Try to add this to Textile
From my point of view, the feature is useful enough only with the first 2 items and we can improve later with 3 and 4. What do you think?
I agree. I think it is still useful even without 2.
#5
Updated by Marius BALTEANU 5 months ago
I've updated the patch to include a test.
#6
Updated by Marius BALTEANU 5 months ago
- File deleted (
0001-Enable-task-list-for-CommonMark-Markdown-formater-35.patch)
#7
Updated by Marius BALTEANU 5 months ago
- File 0002-Adds-task-list-button-to-toolbar-for-CommonMark-form.patch added
- File 0003-Updates-help-file-for-common_mark-to-include-the-tas.patch added
- 0002: adds a task list item button to the JS toolbar
- 0003: updates the help file for en.
Go Maeda, please let me know if I can commit this.
#8
Updated by Marius BALTEANU 4 months ago
- File bt_tl.png added
- Status changed from New to Closed
- Resolution set to Fixed
Feature added in r21383. You can now add task list items using the common_mark format * [ ] Task title or by clicking the "Task list" icon 
from the toolbar.
For now, to check the items, you need to use the Edit feature, we will try to allow this by clicking on the checkbox in the near future.
#9
Updated by Marius BALTEANU 4 months ago
- Related to Feature #20698: Add support for task list items in Textile formatting added