Project

General

Profile

Actions

Feature #35742

closed

Enable task list items for CommonMark text formatting

Added by Marius BĂLTEANU over 2 years ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Category:
Text formatting
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

The task list extensions will be a very nice addition for Common Mark text formatting.

https://github.com/gjtorikian/commonmarker#extensions


Files


Related issues

Related to Redmine - Feature #32424: CommonMark Markdown Text FormattingClosedMarius BĂLTEANU

Actions
Related to Redmine - Feature #20698: Add support for task list items in Textile formattingNew

Actions
Actions #1

Updated by Marius BĂLTEANU over 2 years ago

  • Related to Feature #32424: CommonMark Markdown Text Formatting added
Actions #2

Updated by Marius BĂLTEANU over 2 years ago

  • File 0001-Enable-task-list-for-CommonMark-Markdown-formater-35.patch added

I'm adding a patch for testing purposes, I still need to:

  1. Add tests
  2. Add an icon to JS toolbar
  3. Allow clicking task item checkboxes directly.
  4. Try to add this to Textile

From my point of view, the feature is useful enough only with the first 2 items and we can improve later with 3 and 4. What do you think?

Regarding the tech side, I tried to implement it using only the tasklist extension provided by the CommonMark, but it requires to whitelist in the sanitize the following tags: ul, li, input type="checkbox". Also, using this extensions it will make harder to port this feature to textile.

Actions #3

Updated by Marius BĂLTEANU over 2 years ago

  • Target version set to 5.0.0

I think we should deliver this along with the new CommonMark formatter. Any feedback is appreciated.

Actions #4

Updated by Go MAEDA over 2 years ago

Really nice feature. This should be delivered in Redmine 5.0.0.

Marius BALTEANU wrote:

I'm adding a patch for testing purposes, I still need to:

  1. Add tests
  2. Add an icon to JS toolbar
  3. Allow clicking task item checkboxes directly.
  4. Try to add this to Textile

From my point of view, the feature is useful enough only with the first 2 items and we can improve later with 3 and 4. What do you think?

I agree. I think it is still useful even without 2.

Actions #6

Updated by Marius BĂLTEANU over 2 years ago

  • File deleted (0001-Enable-task-list-for-CommonMark-Markdown-formater-35.patch)
Actions #7

Updated by Marius BĂLTEANU over 2 years ago

Here are other two patches:
  • 0002: adds a task list item button to the JS toolbar
  • 0003: updates the help file for en.

Go Maeda, please let me know if I can commit this.

Actions #8

Updated by Marius BĂLTEANU about 2 years ago

  • File bt_tl.png bt_tl.png added
  • Status changed from New to Closed
  • Resolution set to Fixed

Feature added in r21383. You can now add task list items using the common_mark format * [ ] Task title or by clicking the "Task list" icon from the toolbar.

For now, to check the items, you need to use the Edit feature, we will try to allow this by clicking on the checkbox in the near future.

Actions #9

Updated by Marius BĂLTEANU about 2 years ago

  • Related to Feature #20698: Add support for task list items in Textile formatting added
Actions #10

Updated by Go MAEDA about 2 years ago

  • Subject changed from Enable task list items for Common Mark text formatting to Enable task list items for CommonMark text formatting
Actions #11

Updated by Beni br over 1 year ago

Marius BALTEANU wrote:

For now, to check the items, you need to use the Edit feature, we will try to allow this by clicking on the checkbox in the near future.

Is there any news on this or a issue to track clickable checkboxes?

Thanks for implementing this anyway!

Actions #12

Updated by Gilles Devillers 7 months ago

Any news about this feature? This would really benefit our workflow where be have checklists in notes depending on the current state of the issue.

Actions #13

Updated by Go MAEDA 7 months ago

Since the feature was already delivered as a part of Redmine 5.0.0 and this issue was closed, please don't add comments anymore.

Please open a new issue if you have any requests about the feature.

Actions

Also available in: Atom PDF