Actions
Defect #35754
closedRedmine::WikiFormatting::CommonMark::FormatterTest#test_should_ignore_soft_breaks fails
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
A test added by #32424 fails.
Failure: Redmine::WikiFormatting::CommonMark::FormatterTest#test_should_ignore_soft_breaks [/Users/maeda/redmines/redmine-trunk/test/unit/lib/redmine/wiki_formatting/common_mark/formatter_test.rb:40]: --- expected +++ actual @@ -1,2 +1,2 @@ -"<p>foo +"<p>foo<br> bar</p>" rails test test/unit/lib/redmine/wiki_formatting/common_mark/formatter_test.rb:39
Since hard breaks are enabled by default in the trunk, the test should be changed as follows:
diff --git a/test/unit/lib/redmine/wiki_formatting/common_mark/formatter_test.rb b/test/unit/lib/redmine/wiki_formatting/common_mark/formatter_test.rb
index b92121c55..d121d5425 100644
--- a/test/unit/lib/redmine/wiki_formatting/common_mark/formatter_test.rb
+++ b/test/unit/lib/redmine/wiki_formatting/common_mark/formatter_test.rb
@@ -36,8 +36,8 @@ class Redmine::WikiFormatting::CommonMark::FormatterTest < ActionView::TestCase
assert_equal html, format("foo \nbar")
end
- def test_should_ignore_soft_breaks
- assert_equal "<p>foo\nbar</p>", format("foo\nbar")
+ def test_should_render_soft_breaks
+ assert_equal "<p>foo<br>\nbar</p>", format("foo\nbar")
end
def test_syntax_error_in_image_reference_should_not_raise_exception
Related issues
Updated by Go MAEDA over 3 years ago
- Related to Feature #32424: CommonMark Markdown Text Formatting added
Updated by Marius BĂLTEANU over 3 years ago
- Status changed from New to Closed
- Resolution set to Fixed
Patch committed, thanks for pointing this out.
Actions