Defect #35765
closed
Code with unsupported code language is not render when CommonMark Markdown is used
Added by Marius BĂLTEANU over 3 years ago.
Updated over 3 years ago.
Description
The following code snippet:
```phpvb
<?php
echo "This is with unsupported code!";
is render as following:
In textile and classic Markdown, the code is rendered without any syntax highlight (as exppected).
Files
- Category set to Text formatting
The following patch should fix this
iff --git a/lib/redmine/wiki_formatting/common_mark/syntax_highlight_filter.rb b/lib/redmine/wiki_formatting/common_mark/syntax_highlight_filter.rb
index a027e6a17..c7c43ee8b 100644
--- a/lib/redmine/wiki_formatting/common_mark/syntax_highlight_filter.rb
+++ b/lib/redmine/wiki_formatting/common_mark/syntax_highlight_filter.rb
@@ -39,7 +39,7 @@ module Redmine
node["class"] = "#{lang} syntaxhl"
else
# unsupported language, strip out the code tag
- node.parent.inner_html = text
+ node.parent.inner_html = CGI.escapeHTML(text)
end
end
doc
but also the unified code blocks proposed by Martin in #35104 and #32424#note-39 should do the trick.
- Status changed from New to Closed
Fixed in r21181.
Now we render the code block even if the language is not supported, but we remove the class attribute.
Also available in: Atom
PDF
Updated by