Project

General

Profile

Actions
Copy link

Patch #36817

closed

copyImageFromClipboard function targets the first file input of the page and may conflict with other plugins

Added by Yazan Al aeddin almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Marius BĂLTEANU
Category:
Attachments
Target version:
4.2.6
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Hello,

The function copyImageFromClipboard) targets the first file input of the page and may conflict with other plugins.
On our redmine instance we use the redmine_comments plugin (https://github.com/jbbarth/redmine_comments) that adds the ability to write private note and create a new form.
We experienced a problem as shown in the image1 and image2 ,and when we click on comment as shown in image3
We managed to fix this issue, by replace the line
`var inputEl = $('input:file.filedrop').first();`
by
`var inputEl = $(this).closest("form").find('input:file.filedrop');`

Thank you for your help

Files

Download all files
image1.png (86.5 KB) image1.png Yazan Al aeddin, 2022-03-21 16:24
image2.png (68.1 KB) image2.png Yazan Al aeddin, 2022-03-21 16:24
image3.png (60.8 KB) image3.png Yazan Al aeddin, 2022-03-21 16:24
redmine_tiny_features.png (70.1 KB) redmine_tiny_features.png Yazan Al aeddin, 2022-04-05 09:32
issue_36817.patch (963 Bytes) issue_36817.patch Yazan Al aeddin, 2022-04-15 11:57

Related issues

Copied to Redmine - Defect #36887: copyImageFromClipboard function failed to generate a unique file nameClosedMarius BĂLTEANU

Actions
Actions
Copy link
 #1

Updated by Marius BĂLTEANU almost 3 years ago

  • Assignee set to Marius BĂLTEANU
  • Target version set to Candidate for next minor release
Actions
Copy link
 #2

Updated by Marius BĂLTEANU over 2 years ago

  • Target version changed from Candidate for next minor release to 4.2.6
Actions
Copy link
 #3

Updated by Simon Hori over 2 years ago

  • Copied to Defect #36887: copyImageFromClipboard function failed to generate a unique file name added
Actions
Copy link
 #4

Updated by Marius BĂLTEANU over 2 years ago

I'm trying to reproduce the issue, but the plugin doesn't work on current trunk. Can you help me reproduce?

Actions
Copy link
 #5

Updated by Marius BĂLTEANU over 2 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Marius BĂLTEANU to Yazan Al aeddin
Actions
Copy link
 #6

Updated by Yazan Al aeddin over 2 years ago

Hello
Did you install the plugin (redmine_tiny_features)?
Because the bug is fixed by overriding the method (copyImageFromClipboard).

Actions
Copy link
 #7

Updated by Marius BĂLTEANU over 2 years ago

Yazan Al aeddin wrote:

Hello
Did you install the plugin (redmine_tiny_features)?
Because the bug is fixed by overriding the method (copyImageFromClipboard).

I only tried to install https://github.com/jbbarth/redmine_comments and I saw a new role permission, but nothing else in the UI.

Actions
Copy link
 #8

Updated by Yazan Al aeddin over 2 years ago

Ok I'll see

Actions
Copy link
 #9

Updated by Yazan Al aeddin over 2 years ago

Did you make (rake redmine:plugins:migrate)?

Actions
Copy link
 #10

Updated by Yazan Al aeddin over 2 years ago

Hello
We propose this patch
Thank you for your help.

Actions
Copy link
 #11

Updated by Marius BĂLTEANU over 2 years ago

  • Category set to Attachments
  • Status changed from Needs feedback to Resolved
  • Resolution set to Fixed

Patch committed, thanks!

Actions
Copy link
 #12

Updated by Marius BĂLTEANU over 2 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Yazan Al aeddin to Marius BĂLTEANU
Actions
Copy link
 #13

Updated by Marius BĂLTEANU over 2 years ago

  • Tracker changed from Defect to Patch
Actions
Copy link

Also available in: Atom PDF