Patch #36817
closed
copyImageFromClipboard function targets the first file input of the page and may conflict with other plugins
Description
Hello,
The function copyImageFromClipboard) targets the first file input of the page and may conflict with other plugins.
On our redmine instance we use the redmine_comments plugin (https://github.com/jbbarth/redmine_comments) that adds the ability to write private note and create a new form.
We experienced a problem as shown in the image1 and image2 ,and when we click on comment as shown in image3
We managed to fix this issue, by replace the line
`var inputEl = $('input:file.filedrop').first();`
by
`var inputEl = $(this).closest("form").find('input:file.filedrop');`
Thank you for your help
Files
Related issues
Updated by Marius BĂLTEANU almost 4 years ago
- Assignee set to Marius BĂLTEANU
- Target version set to Candidate for next minor release
Updated by Marius BĂLTEANU almost 4 years ago
- Target version changed from Candidate for next minor release to 4.2.6
Updated by Simon Hori almost 4 years ago
- Copied to Defect #36887: copyImageFromClipboard function failed to generate a unique file name added
Updated by Marius BĂLTEANU almost 4 years ago
I'm trying to reproduce the issue, but the plugin doesn't work on current trunk. Can you help me reproduce?
Updated by Marius BĂLTEANU almost 4 years ago
- Status changed from New to Needs feedback
- Assignee changed from Marius BĂLTEANU to Yazan Al aeddin
Updated by Yazan Al aeddin almost 4 years ago
Hello
Did you install the plugin (redmine_tiny_features)?
Because the bug is fixed by overriding the method (copyImageFromClipboard).
Updated by Marius BĂLTEANU almost 4 years ago
Yazan Al aeddin wrote:
Hello
Did you install the plugin (redmine_tiny_features)?
Because the bug is fixed by overriding the method (copyImageFromClipboard).
I only tried to install https://github.com/jbbarth/redmine_comments and I saw a new role permission, but nothing else in the UI.
Updated by Yazan Al aeddin almost 4 years ago
Did you make (rake redmine:plugins:migrate)?
Updated by Yazan Al aeddin almost 4 years ago
- File issue_36817.patch issue_36817.patch added
Hello
We propose this patch
Thank you for your help.
Updated by Marius BĂLTEANU almost 4 years ago
- Category set to Attachments
- Status changed from Needs feedback to Resolved
- Resolution set to Fixed
Patch committed, thanks!
Updated by Marius BĂLTEANU almost 4 years ago
- Status changed from Resolved to Closed
- Assignee changed from Yazan Al aeddin to Marius BĂLTEANU
Updated by Marius BĂLTEANU almost 4 years ago
- Tracker changed from Defect to Patch