Patch #37507

Normalize HTML in app/views/setttings/_users.html.erb

Added by Holger Just 14 days ago. Updated 13 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:5.1.0

Description

In other settings pages, if there are tabular settings, they are encased in a <div class="tabular settings"> rather than adding the classes fdirectly to the fieldset (e.g. in _authorization.html.erb). This patch adjusts the generated HTML accordingly.

It also removes some special CSS rules for these setting pages which were introduced in r13600. I'm actually not really sure why these rules are there. In a default Redmine, they only move things slightly around in an inconsistent way. With custom themes, these rules have the possibility to mess things up.

In any case, I think those rules can just be removed outright:

  • splitcontentleft / splitcontentright is not used on this partial at all
  • the fieldset and labels should be rendered the same way as on all other pages instead of slightly different paddings / margins.
  • there is no tag with a principal id there

0001-Normalize-HTML-in-settings-_users-remove-broken-CSS-.patch Magnifier (2.63 KB) Holger Just, 2022-07-27 17:48

Associated revisions

Revision 21743
Added by Go MAEDA 13 days ago

Normalize HTML in settings/_users, and remove broken CSS left over from the old times (#37507).

Patch by Holger Just.

History

#1 Updated by Go MAEDA 14 days ago

  • Target version set to 5.1.0

Setting the target version to 5.1.0.

#2 Updated by Go MAEDA 13 days ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the fix. Thank you.

Also available in: Atom PDF