Project

General

Profile

Actions

Patch #37507

closed

Normalize HTML in app/views/settings/_users.html.erb

Added by Holger Just over 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In other settings pages, if there are tabular settings, they are encased in a <div class="tabular settings"> rather than adding the classes fdirectly to the fieldset (e.g. in _authorization.html.erb). This patch adjusts the generated HTML accordingly.

It also removes some special CSS rules for these setting pages which were introduced in r13600. I'm actually not really sure why these rules are there. In a default Redmine, they only move things slightly around in an inconsistent way. With custom themes, these rules have the possibility to mess things up.

In any case, I think those rules can just be removed outright:

  • splitcontentleft / splitcontentright is not used on this partial at all
  • the fieldset and labels should be rendered the same way as on all other pages instead of slightly different paddings / margins.
  • there is no tag with a principal id there

Files

Actions #1

Updated by Go MAEDA over 2 years ago

  • Target version set to 5.1.0

Setting the target version to 5.1.0.

Actions #2

Updated by Go MAEDA over 2 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the fix. Thank you.

Actions #3

Updated by Go MAEDA about 1 year ago

  • Subject changed from Normalize HTML in app/views/setttings/_users.html.erb to Normalize HTML in app/views/settings/_users.html.erb
Actions

Also available in: Atom PDF