Project

General

Profile

Actions
Copy link

Defect #37587

closed

Unnecessary requirement in /lib/redmine/scm/adapters/filesystem_adapter.rb

Added by Mischa The Evil over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Low
Assignee:
Go MAEDA
Category:
Code cleanup/refactoring
Target version:
5.1.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

source:/trunk/lib/redmine/scm/adapters/filesystem_adapter.rb@21772#L24 contains the following statement: 

require 'find'

As far as I can tell this requirement is obsolete and doesn't serve any purpose. None of the module's methods are used in the file and I also don't see any other references to the module.

Actions
Copy link
 #1

Updated by Go MAEDA over 2 years ago

It looks like the `require 'find'` was already unnecessary when FilesystemAdapter was added in r1508.

Setting the target version to 5.1.0.

Actions
Copy link
 #2

Updated by Mischa The Evil over 2 years ago

  • Subject changed from Possibly obsolete requirement in /lib/redmine/scm/adapters/filesystem_adapter.rb to Unnecessary requirement in /lib/redmine/scm/adapters/filesystem_adapter.rb
  • Target version set to 5.1.0

Go MAEDA wrote:

It looks like the `require 'find'` was already unnecessary when FilesystemAdapter was added in r1508.

You're right. It indeed looks like that's the case.

Actions
Copy link
 #3

Updated by Go MAEDA about 2 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix. Thank you.

Actions
Copy link

Also available in: Atom PDF