Actions
Defect #37718
closed
Repository browser does not show "+" (plus sign) in filename
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
As reported in the forum post , plus sings in filenames are not displayed in the repository browser when browsing a Subversion repository.
Files
Related issues
Updated by Go MAEDA over 2 years ago
This issue is appeared to be caused by r19455 that replaced URI.escape with CGI.escape at source:trunk/lib/redmine/scm/adapters/subversion_adapter.rb@19455#L111.
$ irb
irb(main):001:0> RUBY_VERSION
=> "2.6.9"
irb(main):002:0> require 'cgi'
=> true
irb(main):003:0> CGI.unescape('+.txt')
=> " .txt"
irb(main):004:0> URI.unescape('+.txt')
=> "+.txt"
Updated by Go MAEDA over 2 years ago
- Related to Defect #32752: Ruby 2.7: Remove deprecated URI.escape/unescape added
Updated by Go MAEDA over 2 years ago
- File 0001-Subversion-adapter-cannot-handle-filenames-containin.patch 0001-Subversion-adapter-cannot-handle-filenames-containin.patch added
Attaching a patch to fix the issue.
Updated by Go MAEDA over 2 years ago
- Target version set to Candidate for next minor release
Updated by Go MAEDA over 2 years ago
- Subject changed from Repository browser does not show plus sign in filename to Repository browser does not show "+" (plus sign) in filename
Updated by Go MAEDA about 2 years ago
- Target version changed from Candidate for next minor release to 4.2.9
Setting the target version to 4.2.9.
Updated by Marius BĂLTEANU about 2 years ago
- Assignee set to Marius BĂLTEANU
- Target version changed from 4.2.9 to 4.2.8
Updated by Marius BĂLTEANU about 2 years ago
- Status changed from New to Resolved
- Resolution set to Fixed
I've committed and merged the fix to 5.0-stable and 4.2-stable branches with one mention: for 4.2-stable, I've backport only the fix because the changes to the tests do not apply cleanly (caused by #16849).
Updated by Marius BĂLTEANU about 2 years ago
- Status changed from Resolved to Closed
Actions