Project

General

Profile

Actions
Copy link

Defect #37718

closed

Repository browser does not show "+" (plus sign) in filename

Added by Go MAEDA over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Marius BĂLTEANU
Category:
SCM
Target version:
4.2.8
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
4.2.0

Description

As reported in the forum post Cannot browse file contents that filename contains "+" i..., plus sings in filenames are not displayed in the repository browser when browsing a Subversion repository.

Files

0001-Subversion-adapter-cannot-handle-filenames-containin.patch (38 KB) 0001-Subversion-adapter-cannot-handle-filenames-containin.patch Go MAEDA, 2022-09-28 06:55

Related issues

Related to Redmine - Defect #32752: Ruby 2.7: Remove deprecated URI.escape/unescapeClosedGo MAEDA

Actions
Actions
Copy link
 #1

Updated by Go MAEDA over 1 year ago

This issue is appeared to be caused by r19455 that replaced URI.escape with CGI.escape at source:trunk/lib/redmine/scm/adapters/subversion_adapter.rb@19455#L111.

$ irb
irb(main):001:0> RUBY_VERSION
=> "2.6.9" 
irb(main):002:0> require 'cgi'
=> true
irb(main):003:0> CGI.unescape('+.txt')
=> " .txt" 
irb(main):004:0> URI.unescape('+.txt')
=> "+.txt"
Actions
Copy link
 #2

Updated by Go MAEDA over 1 year ago

  • Related to Defect #32752: Ruby 2.7: Remove deprecated URI.escape/unescape added
Actions
Copy link
 #3

Updated by Go MAEDA over 1 year ago

  • Affected version set to 4.2.0
Actions
Copy link
 #5

Updated by Go MAEDA over 1 year ago

  • Target version set to Candidate for next minor release
Actions
Copy link
 #6

Updated by Go MAEDA over 1 year ago

  • Subject changed from Repository browser does not show plus sign in filename to Repository browser does not show "+" (plus sign) in filename
Actions
Copy link
 #7

Updated by Go MAEDA over 1 year ago

  • Target version changed from Candidate for next minor release to 4.2.9

Setting the target version to 4.2.9.

Actions
Copy link
 #8

Updated by Marius BĂLTEANU over 1 year ago

  • Assignee set to Marius BĂLTEANU
  • Target version changed from 4.2.9 to 4.2.8
Actions
Copy link
 #9

Updated by Marius BĂLTEANU over 1 year ago

  • Status changed from New to Resolved
  • Resolution set to Fixed

I've committed and merged the fix to 5.0-stable and 4.2-stable branches with one mention: for 4.2-stable, I've backport only the fix because the changes to the tests do not apply cleanly (caused by #16849).

Actions
Copy link
 #10

Updated by Marius BĂLTEANU over 1 year ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF