Defect #37732
closed
Fix "DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated" in RepositoriesController
0%
Description
The fix for #37626 introduce a deprecation warning and we should properly fix the issue.
Related issues
Updated by Marius BĂLTEANU about 2 years ago
- Subject changed from Fix DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated in RepositoriesController to Fix "DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated" in RepositoriesController
- Description updated (diff)
Updated by Go MAEDA almost 2 years ago
- Related to Defect #37626: Diff of a javascript file in repository module is not displayed with layout added
Updated by Go MAEDA 11 months ago
After Rails was updated to 7.1 in r22488, RepositoriesController#diff always fails with the following error. The error is due to the change made by r21883.
Missing template, responding with 404: Missing template layouts/base.html.erb with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :rsb]}.
Although r21883 was necessary to fix the problem that the layout is not applied for the diff of .js files (#37626), I think the change should be reverted at this point. Currently, the diff feature is not available for all file types, but if r21883 is reverted, diff will be available for all but a few file extensions.
I think we should revert r21883 and then figure out how to solve the issue reported in #37626.
Updated by Marius BĂLTEANU 11 months ago
- Related to Feature #36320: Migrate to Rails 7.2 added
Updated by Marius BĂLTEANU 11 months ago
- Status changed from New to Closed
- Assignee set to Marius BĂLTEANU
- Target version deleted (
6.0.0) - Resolution set to Fixed
Go MAEDA wrote in #note-5:
After Rails was updated to 7.1 in r22488,
RepositoriesController#diffalways fails with the following error. The error is due to the change made by r21883.[...]
Although r21883 was necessary to fix the problem that the layout is not applied for the diff of .js files (#37626), I think the change should be reverted at this point. Currently, the diff feature is not available for all file types, but if r21883 is reverted, diff will be available for all but a few file extensions.
I think we should revert r21883 and then figure out how to solve the issue reported in #37626.
I totally agree, reverted r21883. I'm removing this from 6.0.0, is part of #36320.