Defect #37881

Thumbnails are no longer fetched for all notes of an issue

Added by Ambright GmbH 3 months ago. Updated about 1 month ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Text formatting
Target version:5.0.5
Resolution:Fixed Affected version:5.0.3

Description

Hello. In Redmine 4 one could upload an attachment and use its file name in a thumbnail-macro in all issue comments (aka notes, aka journal). With version 5 the thumbnail is shown only in the comment, with which an image was uploaded, and if one reuses the macro code in other comments, then an error is shown "Error executing the thumbnail macro (test.jpg not found)"

37881-confirmed.jpg (154 KB) Go MAEDA, 2022-11-07 06:54

fix-37881.patch Magnifier (1.78 KB) Mizuki ISHIKAWA, 2022-12-21 02:08


Related issues

Related to Redmine - Defect #37379: Thumbnail macro does not work when a file is attached and... Closed
Related to Redmine - Defect #37130: Wiki notation `attachment:file_name` cannot make a link t... Closed
Duplicated by Redmine - Defect #38209: Error executing the thumbnail macro (Attachment image.png... Closed

Associated revisions

Revision 22012
Added by Go MAEDA about 1 month ago

Fix `

Error executing the thumbnail macro (Filename required)
` macro in an issue note cannot fetch an image attached in a different note (#37881).

Patch by Mizuki ISHIKAWA.

Revision 22018
Added by Go MAEDA about 1 month ago

Merged r22012 from trunk to 5.0-stable (#37881).

History

#1 Updated by Go MAEDA 3 months ago

Confirmed the issue.

The macro {{thumbnail}} works only if the image is attached to the same journal where the macro is embedded. In the following screenshot, {{thumbnail(IMG_6964.JPG)}} works in note-3 but does not in note-4.

This issue looks similar to #37379.

#2 Updated by Go MAEDA 3 months ago

  • Related to Defect #37379: Thumbnail macro does not work when a file is attached and preview is displayed immediately added

#3 Updated by Mizuki ISHIKAWA about 1 month ago

Patch attached.
I have made similar changes in #37130.

#4 Updated by Go MAEDA about 1 month ago

  • Related to Defect #37130: Wiki notation `attachment:file_name` cannot make a link to a file attached to other journals added

#5 Updated by Go MAEDA about 1 month ago

  • Target version set to 5.0.5

Setting the target version to 5.0.5.

#6 Updated by Go MAEDA about 1 month ago

  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix. Thank you.

#7 Updated by Go MAEDA about 1 month ago

  • Status changed from Resolved to Closed

#8 Updated by Go MAEDA 8 days ago

  • Duplicated by Defect #38209: Error executing the thumbnail macro (Attachment image.png not found) when uploaded in note from MacOS Firefox 109 added

Also available in: Atom PDF