Project

General

Profile

Actions

Defect #38114

closed

Example plugin (extra/sample_plugin) breaks Activity page

Added by Go MAEDA over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Documentation
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

If you install Example Plugin, it breaks Activity Page.

From what I have found, this problem already exists in Redmine 3.4 (I have not checked Redmine 3.3 or earlier versions).

$ cp -a extra/sample_plugin plugins/
$ bin/rake db:migrate redmine:plugins:migrate RAILS_ENV=test
$ bin/rails test test/functional/activities_controller_test.rb
Run options: --seed 46703

# Running:

..DEPRECATION WARNING: acts_as_activity_provider with implicit :scope option is deprecated. Please pass a scope on the Meeting as a proc. (called from block (2 levels) in events at /Users/maeda/redmines/redmine-trunk/lib/redmine/activity/fetcher.rb:93)
E

Error:
ActivitiesControllerTest#test_global_index:
ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: projects.status
    lib/plugins/acts_as_activity_provider/lib/acts_as_activity_provider.rb:90:in `find_events'
    lib/redmine/activity/fetcher.rb:93:in `block (2 levels) in events'
    lib/redmine/activity/fetcher.rb:92:in `each'
    lib/redmine/activity/fetcher.rb:92:in `block in events'
    lib/redmine/activity/fetcher.rb:91:in `each'
    lib/redmine/activity/fetcher.rb:91:in `events'
    app/controllers/activities_controller.rb:62:in `index'
    lib/redmine/sudo_mode.rb:61:in `sudo_mode'
    test/functional/activities_controller_test.rb:70:in `test_global_index'

rails test test/functional/activities_controller_test.rb:68

Files

sample_plugin.patch (604 Bytes) sample_plugin.patch Karel Pičman, 2023-01-26 16:31
Actions #1

Updated by Karel Pičman about 1 year ago

This patch should fix it.

Actions #2

Updated by Go MAEDA about 1 year ago

  • Target version set to 4.2.10

Karel Pičman wrote:

This patch should fix it.

Thank you, I have confirmed that the patch fixes the issue.

Setting the target version to 4.2.10.

Actions #3

Updated by Go MAEDA about 1 year ago

  • Subject changed from Example plugin (extra/sample_plugin) does not wok to Example plugin (extra/sample_plugin) breaks Activity page
  • Status changed from New to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for your contribution.

Actions #4

Updated by Go MAEDA about 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF