Project

General

Profile

Actions
Copy link

Feature #38216

closed

Add template filenames as comments to HTML output in development mode

Added by Takashi Kato almost 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Rails support
Target version:
5.1.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

This patch adds HTML comments to the rendered output indicating where each template begins and ends in development and test mode.

This feature has been added since rails 6.1.

see
.annotate_template_file_names annotates HTML output with template names #38848
Add the configuration option for annotating templates with file names to the generated app #39204

Files

Download all files
erb_filenames.png (162 KB) erb_filenames.png Takashi Kato, 2023-01-28 08:03
0001-Add-template-filenames-as-comments-to-HTML-output-de.patch (1.36 KB) 0001-Add-template-filenames-as-comments-to-HTML-output-de.patch Takashi Kato, 2023-01-28 08:03
Actions
Copy link
 #1

Updated by Go MAEDA almost 2 years ago

  • Target version set to Candidate for next major release

Thank you for posting the patch. Enabling the feature in development mode is very useful. However, I think enabling the feature by default only in development mode is better because it breaks existing tests.

Failure:
HookTest#test_multiple_hooks [/Users/maeda/redmines/redmine-trunk/test/integration/lib/redmine/hook_test.rb:124]:
Expected: 1
  Actual: 0

rails test test/integration/lib/redmine/hook_test.rb:120

Failure:
HookTest#test_multiple_hooks [/Users/maeda/redmines/redmine-trunk/test/integration/lib/redmine/hook_test.rb:124]:
Expected: 1
  Actual: 0

rails test test/integration/lib/redmine/hook_test.rb:120
Actions
Copy link
 #2

Updated by Go MAEDA almost 2 years ago

  • Subject changed from Add template filenames as comments to HTML output development in development and test mode to Add template filenames as comments to HTML output in development mode
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version changed from Candidate for next major release to 5.1.0

Enabled annotate_rendered_view_with_filenames in development mode.

Thank you for your contribution.

Actions
Copy link
 #3

Updated by Go MAEDA about 1 year ago

  • Tracker changed from Patch to Feature
  • Resolution set to Fixed
Actions
Copy link

Also available in: Atom PDF