Project

General

Profile

Actions

Defect #39778

closed

Untranslated string "OK" in the repository browser

Added by Mischa The Evil 11 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
I18n
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:


Related issues

Related to Redmine - Defect #38509: Untranslated string "OK" in the repository browserClosedGo MAEDA

Actions
Actions #1

Updated by Mischa The Evil 11 months ago

  • Related to Defect #38509: Untranslated string "OK" in the repository browser added
Actions #2

Updated by Mischa The Evil 11 months ago

Off-topic:

Mischa The Evil wrote:

Defect #38509#note-4: Untranslated string "OK" in the repository browser:

Woot! This syntax actually works... Neat! Thumbs up to Jens Krämer et al.

Actions #3

Updated by salman mp 11 months ago

+1

Actions #4

Updated by Go MAEDA 2 months ago

  • Target version set to 5.1.4

Thank you for pointing out. I had to include the following change in r22231.

diff --git a/app/views/repositories/diff.html.erb b/app/views/repositories/diff.html.erb
index 3551c38c4..8af09e70e 100644
--- a/app/views/repositories/diff.html.erb
+++ b/app/views/repositories/diff.html.erb
@@ -23,7 +23,7 @@
                :rev        => nil},
                :method     => :get) do %>
     <%= text_field_tag 'rev', @rev, :size => 8 %>
-    <%= submit_tag 'OK', :name => nil %>
+    <%= submit_tag l(:button_view), :name => nil %>
   <% end %>
 </div>
 <%= render :partial => 'changeset' %>

Actions #5

Updated by Go MAEDA 2 months ago

  • Status changed from New to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix in r22983.

Actions #6

Updated by Go MAEDA 2 months ago

  • Status changed from Resolved to Closed

Merged the fix to 5.1-stable branch.

Actions

Also available in: Atom PDF