Project

General

Profile

Actions
Copy link

Defect #40166

closed

Internationalize "Check all / Uncheck all" tooltip in project list for admins

Added by Liane Hampe 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Administration
Target version:
5.1.2
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Since Redmine 5.1 there is a new project list for admins using the same query interface as known on projects index page.

With this new project list there is a checkbox on the left for each project in the list.

Check all/Uncheck all not localized

Hovering over the top checkbox displays a tooltipp with "Check all/Uncheck all". For an improved usability and consistency it would help to localize the tooltipp content.

This can be done in app/views/projects/_list.html.erb. Hier ist the relevant code snippet:

<table class="list projects odd-even <%= @query.css_classes %>">
<thead>
  <tr>
    <% if @admin_list %>
      <th class="checkbox hide-when-print">
        <input type="checkbox" name="check_all" id="check_all" value="" class="toggle-selection" title="Check all/Uncheck all"> <--- Not localized text string!
      </th>
    <% end %>
    <% @query.inline_columns.each do |column| %>
      <%= column_header(@query, column) %>
    <% end %>
    <% if @admin_list %>
      <th></th>
    <% end %>
  </tr>
</thead>

Files

Download all files
clipboard-202401311510-5gnwp.png (7.61 KB) clipboard-202401311510-5gnwp.png Check all/Uncheck all not localized Liane Hampe, 2024-01-31 15:10
0001-Internationalize-Check-all-Uncheck-all-tooltip-in-pr.patch (1010 Bytes) 0001-Internationalize-Check-all-Uncheck-all-tooltip-in-pr.patch Go MAEDA, 2024-02-01 01:12
0002-Add-spaces-around-the-slash-for-consistency-and-bett.patch (6.9 KB) 0002-Add-spaces-around-the-slash-for-consistency-and-bett.patch Go MAEDA, 2024-02-01 01:12
Actions
Copy link
 #1

Updated by Go MAEDA 10 months ago

  • Tracker changed from Feature to Defect
  • Category changed from Issues list to Administration
  • Status changed from New to Confirmed
  • Target version set to 5.1.2

The following change fixes the issue.
Setting the target version to 5.1.2.

diff --git a/app/views/projects/_list.html.erb b/app/views/projects/_list.html.erb
index 1bc8d4687..6fd3b7047 100644
--- a/app/views/projects/_list.html.erb
+++ b/app/views/projects/_list.html.erb
@@ -8,7 +8,8 @@
   <tr>
     <% if @admin_list %>
       <th class="checkbox hide-when-print">
-        <input type="checkbox" name="check_all" id="check_all" value="" class="toggle-selection" title="Check all/Uncheck all">
+        <%= check_box_tag 'check_all', '', false, :class => 'toggle-selection',
+              :title => "#{l(:button_check_all)} / #{l(:button_uncheck_all)}" %>
       </th>
     <% end %>
     <% @query.inline_columns.each do |column| %>
Actions
Copy link
 #3

Updated by Go MAEDA 10 months ago

  • Subject changed from Localize "Check all/Uncheck all" tooltip in project list for admins to Internationalize "Check all / Uncheck all" tooltip in project list for admins
  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix in r22675. Thank you for reporting the issue.

Actions
Copy link
 #4

Updated by Go MAEDA 10 months ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF