Defect #41079
closed
Incorrect sorting of users grouped by status in issue filters for administrators
Added by Vladislav Moiseev 4 months ago. Updated 4 months ago.
0%
Description
In #15201 default sorting for filter options linked with principals (users) was changed.
And now principal options into issue query filters for system admins was broken.
Attached patch for current trunk is fixed this problem.
Redmine instance infoRedmine instance info
Environment: Redmine version 5.1.3.stable Ruby version 3.2.5-p208 (2024-07-26) [x86_64-linux-musl] Rails version 6.1.7.8 Environment production Database adapter PostgreSQL Mailer queue ActiveJob::QueueAdapters::AsyncAdapter Mailer delivery smtp Redmine settings: Redmine theme Default SCM: Subversion 1.14.3 Mercurial 6.7.4 Bazaar 3.3.4 Git 2.45.2 Filesystem GitRemote 2.45.2 Redmine plugins: redmine_git_remote 0.0.3 redmine_issue_templates 1.1.2
Files
| query.rb.patch (1.39 KB) query.rb.patch | Vladislav Moiseev, 2024-07-30 20:33 | ||
| clipboard-202407311446-b3ipf.png (163 KB) clipboard-202407311446-b3ipf.png | Go MAEDA, 2024-07-31 07:46 | ||
| 2024-07-31_16-29-40.png (132 KB) 2024-07-31_16-29-40.png | Vladislav Moiseev, 2024-07-31 14:34 | ||
| users.csv (973 Bytes) users.csv | Vladislav Moiseev, 2024-07-31 14:35 | ||
| 2024-07-31_16-33-00.png (76.5 KB) 2024-07-31_16-33-00.png | Vladislav Moiseev, 2024-07-31 14:36 | ||
| test-41079.patch (894 Bytes) test-41079.patch | Go MAEDA, 2024-08-04 14:44 |
Related issues
Updated by Vladislav Moiseev 4 months ago
- File 2024-07-31_16-29-40.png 2024-07-31_16-29-40.png added
- File users.csv users.csv added
- File 2024-07-31_16-33-00.png 2024-07-31_16-33-00.png added
To reproduce this behaviour I installed new redmine instance with default configuration (English).
Then I imported users from users.csv (attached) using default wizard config like this:
Then I created new project, linked all active users and one locked ("ddd" in my case) as managers.
And.. filter sorting was broken:
Updated by Go MAEDA 4 months ago
- File test-41079.patch test-41079.patch added
- Target version set to Candidate for next minor release
I wrote a test to catch the wrong behavior.
$ bin/rails test test/unit/query_test.rb:3348 Run options: --seed 31819 # Running: F Failure: QueryTest#test_assigned_to_values_should_be_sorted_by_status_and_name [test/unit/query_test.rb:3360]: --- expected +++ actual @@ -1 +1 @@ -["000 000", "002 002", "004 004", "006 006", "008 008", "010 010", "012 012", "014 014", "016 016", "018 018", "001 001", "003 003", "005 005", "007 007", "009 009", "011 011", "013 013", "015 015", "017 017", "019 019"] +["018 018", "016 016", "014 014", "012 012", "010 010", "008 008", "006 006", "004 004", "002 002", "000 000", "007 007", "009 009", "005 005", "011 011", "013 013", "003 003", "015 015", "017 017", "001 001", "019 019"] bin/rails test test/unit/query_test.rb:3348
Updated by Go MAEDA 4 months ago
- Related to Feature #15201: Filter "Assignee" should contain locked users added
Updated by Go MAEDA 4 months ago
- Subject changed from Wrong principal sorting into issue filters for sys-admins to Incorrect sorting of users grouped by status in issue filters for administrators
- Status changed from Resolved to Closed
- Target version changed from 5.0.10 to 5.1.4
Merged the change to the 5.1-stable branch.
Updated by Go MAEDA 3 months ago
- Has duplicate Defect #33616: Assignee & Author Dropdown Sort added