Project

General

Profile

Actions

Patch #42133

open

Refactor thumbnail markup for improved structure and semantics

Added by Go MAEDA about 14 hours ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Attachments
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

This patch, authored by Katsuya HIDAKA (Katsuya HIDAKA), was extracted from #42084.

In #42084, two patches were proposed: one by Mizuki ISHIKAWA (Mizuki ISHIKAWA) (committed as r23452) and another by Katsuya HIDAKA. Since the fix needed to be backported to the 6.0-stable branch, I decided to commit Mizuki ISHIKAWA's patch, which involved minimal changes to the DOM.

On the other hand, Katsuya HIDAKA's patch includes the following improvements:

  • The title attribute of the img tag, which was the root cause of the issue, is removed while preserving the tooltip position improvements introduced in #41272.
  • The img tag no longer has both alt and title attributes with identical values, improving accessibility.
  • A class attribute is added to the div tag wrapping the img tag, making styling easier.

To incorporate these enhancements as a refactoring for the next major release, Redmine 6.1, I have opened this new issue.


Files


Related issues

Related to Redmine - Defect #42084: Placeholder icon for non-existent thumbnail flickers rapidly on hoverResolvedGo MAEDA

Actions
Actions #1

Updated by Go MAEDA about 14 hours ago

  • Related to Defect #42084: Placeholder icon for non-existent thumbnail flickers rapidly on hover added
Actions

Also available in: Atom PDF