Defect #42233: Float custom values with ',' as decimal separator are not converted to '.' and cause SQL errors when sorting or summing - Redmine

Custom queries

Documentation issues
Open defects
Open features
Patch queue
Plugin issues
Translation patches

Actions

Copy link

Defect #42233

closed

Float custom values with ',' as decimal separator are not converted to '.' and cause SQL errors when sorting or summing

Added by Grischa Zengel 2 months ago. Updated 2 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Go MAEDA

Category:

Custom fields

Target version:

6.0.4

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

6.0.3

Description

If using german language settings redmine shows value 1.5 as 1,5.
You can put 1,5 to a numeric field. Redmine shows this a 1,0 on overview.
In tables, if you sort a field with this value you get error 500.
If you want a sum over this field you get error 500, too.

With english language settings it's not possible to put 1,5 to a numeric field.

Files

42233.patch (2.59 KB) 42233.patch

Go MAEDA, 2025-02-07 06:55

Related issues

Related to Redmine - Feature #22024: Support localized decimal separators for float values

Closed

Go MAEDA

Actions

Has duplicate Redmine - Defect #42330: Custom Floating Point Field Truncating Decimal Part

Closed

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Go MAEDA 2 months ago

Related to Feature #39997: Add an option to render values of Integer- and Float-format custom fields with thousands delimiters added

Actions

Copy link

Updated by Go MAEDA 2 months ago

Related to Feature #22024: Support localized decimal separators for float values added

Actions

Copy link

Updated by Go MAEDA 2 months ago

Related to deleted (Feature #39997: Add an option to render values of Integer- and Float-format custom fields with thousands delimiters)

Actions

Copy link

Updated by Go MAEDA 2 months ago

File 42233.patch 42233.patch added
Status changed from New to Confirmed
Target version set to Candidate for next minor release

Thank you for reporting this issue. The problem occurs because, when using German language settings, Redmine allows the input of 1,5 (with a comma as the decimal separator) into numeric fields. However, this value is not properly converted to 1.5 (with a period as the decimal separator) before being saved in the custom_values table. As a result, the value remains as 1,5 in the database, causing errors during sorting or summation.

I have wroate a patch to address this issue. Once applied, the patch ensures that any new input like 1,5 is correctly converted to 1.5 before being saved to the database. However, please note that this patch does not automatically fix existing data that has already been saved with a comma as the decimal separator.

To correct existing data, you can do one of the following:
1. Open the issue edit page, manually change the decimal separator from `,` to `.` in the custom field value, and save the issue.
2. Apply the patch, then open the issue edit page and save it without making any changes. This will update the value to use a period as the decimal separator.

Actions

Copy link

Updated by Go MAEDA 2 months ago

Subject changed from Query::StatementInvalid: PG::InvalidTextRepresentation: ERROR: invalid input syntax for type numeric: ",5" to Float custom values with ',' as decimal separator are not converted to '.' and cause SQL errors when sorting or summing
Category set to Custom fields
Target version changed from Candidate for next minor release to 6.0.4

Setting the target version to 6.0.4.

Actions

Copy link

Updated by Grischa Zengel 2 months ago

I patched my Redmine and it's working. Thanks for it.

It's different to time entries. If I edit an existing time entry it will show me a comma in the hours field.
I can put point or comma and it shows everywhere a comma.

For user fields I can put comma or point. It shows me everywhere a comma except if I edit this field, it will show me a point.

Actions

Copy link

Updated by Go MAEDA 2 months ago

Grischa Zengel wrote in #note-6:

I patched my Redmine and it's working. Thanks for it.

Thank you for your feedback.

It's different to time entries. If I edit an existing time entry it will show me a comma in the hours field.
I can put point or comma and it shows everywhere a comma.

For user fields I can put comma or point. It shows me everywhere a comma except if I edit this field, it will show me a point.

I will handle this in a new issue.

Actions

Copy link