Project

General

Profile

Actions
Copy link

Patch #42445

closed

Remove extra condition in User#notify_about?

Added by Nishida Yuya about 1 month ago. Updated 29 days ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In User#notify_about?, the case of mail_notification.blank? is never. Because User#set_mail_notification (before_create) sets Setting.default_notification_option if blank.

So we can remove its condition. This patch removes it.

Files

0001-refactor-remove-extra-condition.patch (696 Bytes) 0001-refactor-remove-extra-condition.patch Nishida Yuya, 2025-03-19 15:29
Actions
Copy link
 #1

Updated by Go MAEDA about 1 month ago

  • Target version set to 6.1.0

Setting the target version to 6.1.0.

Actions
Copy link
 #2

Updated by Go MAEDA about 1 month ago

  • Target version changed from 6.1.0 to Candidate for next minor release

Although the users.mail_notification column is set to true when creating a user object, it is possible to set this column to blank by manually executing an SQL statement. Therefore, I believe it would be better to keep the current code as it is.

What is your opinion on this?

Actions
Copy link
 #3

Updated by Nishida Yuya about 1 month ago

it is possible to set this column to blank by manually executing an SQL statement.

I see. Thanks comment! I understood that I also need to consider the case when SQL is manually executed, so this patch (0001-refactor-remove-extra-condition.patch) and issue are incorrect.

Instead, I found a bug about manual executing SQL. Its details and patch is in #42467 .

Actions
Copy link
 #4

Updated by Go MAEDA 29 days ago

  • Status changed from New to Closed
  • Target version deleted (Candidate for next minor release)
Actions
Copy link

Also available in: Atom PDF