Patch #4520

Simplify URL Matching in Redmine

Added by Christoph Rauch almost 12 years ago. Updated almost 12 years ago.

Status:NewStart date:2010-01-05
Priority:LowDue date:
Assignee:-% Done:

0%

Category:Text formatting
Target version:-

Description

In our local Redmine Installation I use this patch to link to arbitrary protocols, e.g. on Ubuntu apt://rake installs rake upon clicking.

In order not to build every possible protocol into the regexp I simple replaced it with "some printable characters". This is obviously overly eager. For example foohttp://www.example.com/ does match with protocol "foohttp", whereas previously it would be recognized correctly.

Anyway, even if you won't include it I'll leave it here, in case someone could use it.

Thanks for this great project!

0004-url-matching.patch Magnifier - Patch to match all possible protocols, yet breaking some other matches. (715 Bytes) Christoph Rauch, 2010-01-05 15:21

History

#1 Updated by Christian Sowada almost 12 years ago

Good Patch,
i've searched a protocol extension for Lotus Notes Links.
I hope that somthing like this patch goes into the release.

Thanks

#2 Updated by Eric Davis almost 12 years ago

This patch would match the javascript: link which could be a security risk.

Also available in: Atom PDF