Project

General

Profile

Actions

Patch #4520

closed

Simplify URL Matching in Redmine

Added by Christoph Rauch about 14 years ago. Updated 5 days ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
Text formatting
Target version:
-
Start date:
2010-01-05
Due date:
% Done:

0%

Estimated time:

Description

In our local Redmine Installation I use this patch to link to arbitrary protocols, e.g. on Ubuntu apt://rake installs rake upon clicking.

In order not to build every possible protocol into the regexp I simple replaced it with "some printable characters". This is obviously overly eager. For example foohttp://www.example.com/ does match with protocol "foohttp", whereas previously it would be recognized correctly.

Anyway, even if you won't include it I'll leave it here, in case someone could use it.

Thanks for this great project!


Files

0004-url-matching.patch (715 Bytes) 0004-url-matching.patch Patch to match all possible protocols, yet breaking some other matches. Christoph Rauch, 2010-01-05 15:21
Actions #1

Updated by Christian Sowada about 14 years ago

Good Patch,
i've searched a protocol extension for Lotus Notes Links.
I hope that somthing like this patch goes into the release.

Thanks

Actions #2

Updated by Eric Davis about 14 years ago

This patch would match the javascript: link which could be a security risk.

Actions #3

Updated by Holger Just 5 days ago

  • Status changed from New to Closed

Auto-linking (i.e. when just writing a plain URL in the text field) is still restricted to the http/https or ftp/ftps protocols, both in Textile and the two Markdown implementations. While it is debatable if ftp links should be auto-linked nowadays, I don't think we should expand the list of protocols to avoid false-positives.

In any case, you can write explicit links with these protocols today, e.g. "Rake package":apt://rake will be rendered as Rake package when using Textile.

With your patch, the security implications mentioned by Eric still apply. As such, we should not add it to Redmine as is. I'd still like thank you for your contribution, even if rather belated :)

Actions

Also available in: Atom PDF