Project

General

Profile

Actions
Copy link

Defect #5339

closed

LDAP authenication only work if onthefly_register is set (upgrade 0.8.5 to 0.9.3 fails)

Added by Daniel Bond about 14 years ago. Updated about 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
LDAP
Target version:
-
Start date:
2010-04-16
Due date:
% Done:

0%

Estimated time:
1.00 h
Resolution:
Invalid
Affected version:
0.9.3

Description

I've been trying to upgrade Redmine 0.8.5 to 0.9.3, but after upgrade LDAP logins stopped working. I've poked a bit around with ruby-debug, and the source of the problem in models/auth_source.rb line 38:

=> 38      AuthSource.find(:all, :conditions => ["onthefly_register=?", true]).each do |source|

The reason LDAP logins didn't work for me, was that "onthefly_register" setting was not set. I suspect this could affect other users upgrading to 0.9.3 also.

I have a couple suggestions how to fix it:

  1. remove the check for "onthefly_register" in line 38, because it seems unnecessary
  2. update the UpgradingRedmine wiki-page to mention how to fix it. (or mention in changelog)

I'd be happy to fix this, but would like input on how to fix it, so I'm more certain it's the right thing to do.

Actions
Copy link

Also available in: Atom PDF