Defect #5452
closed
Member role forms in project settings are not hidden after member added
Added by Yuki Kita over 14 years ago.
Updated over 14 years ago.
Description
Member role forms in project settings should be hidden by default.
And we click [edit] button to see them.
But if I add some member to a project, all member role forms are shown.
So I have to click [cancel] button one by one to hide them.
It seems that the behavior was changed after the fix for #4852 ( r3483 ).
Because the load event handler bellow is not called after member added.
Event.observe(window, 'load', function() {
$$('.hol').each(function(el) {
el.hide();
});
});
Files
- Category set to UI
- Target version set to 0.9.5
I have also had that problem on at least one of my installations. I'll try to go through all of them and post the version numbers.
See patches attached for application.js and _members.rhtml
The name of the function hideRoles could be change if not appropriate.
Alain Gandon wrote:
See patches attached for application.js and _members.rhtml
The name of the function hideRoles could be change if not appropriate.
Thanks for your cooperation.
The patch works fine.
But I noticed that there still remains some code to be fixed.
So I updated your patch.
But I noticed that there still remains some code to be fixed.
Member role forms are shown not only after member added, but also after member deleted and member role changed.
Updated the patch to reflect the current trunk.
- Status changed from New to Resolved
- Assignee set to Eric Davis
- % Done changed from 0 to 100
- Resolution set to Fixed
Fixed in r3784. I did it a little differently and had the RJS in the MembersController send hideOnLoad()
to the page itself. Thank you for the contribution.
- Status changed from Resolved to Closed
Merged to 0.9-stable for release.
Also available in: Atom
PDF