Project

General

Profile

Actions
Copy link

Defect #5820

closed

Hard-coded string "no subject" in app/models/mail_handler.rb

Added by Roland Discein over 14 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
I18n
Target version:
4.1.0
Start date:
2010-07-05
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

    if issue.subject.blank?
      issue.subject = '(no subject)'
    end
hardcoded in source:app/models/mail_handler.rb

Maybe it can be localized?

My env:

About your application's environment
Ruby version 1.8.7 (i486-linux)
RubyGems version 1.3.7
Rack version 1.0
Rails version 2.3.5
Active Record version 2.3.5
Active Resource version 2.3.5
Action Mailer version 2.3.5
Active Support version 2.3.5
Application root /opt/redmine
Environment development
Database adapter mysql
Database schema version 20100313171051

Files

feature-5820.patch (2.05 KB) feature-5820.patch Mizuki ISHIKAWA, 2019-08-22 10:28
Actions
Copy link
 #1

Updated by Roland Discein over 14 years ago

Mistyped: hardcoded entry in source:/trunk/app/models/mail_handler.rb

russian translation is

field_no_subject: Нет темы
Actions
Copy link
 #2

Updated by Mizuki ISHIKAWA over 5 years ago

I attached a patch.
The subject language is Setting.default_language, not the user language(The reason is the same as #31427#note-9)

Actions
Copy link
 #3

Updated by Go MAEDA over 5 years ago

  • Category set to I18n
  • Target version set to 4.1.0

Setting the target version to 4.1.0.

Actions
Copy link
 #4

Updated by Go MAEDA over 5 years ago

  • Tracker changed from Feature to Defect
  • Subject changed from Issues with no subject can have localized title to Hard-coded string "no subject" in app/models/mail_handler.rb
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for your contribution.

Actions
Copy link

Also available in: Atom PDF