Project

General

Profile

Actions
Copy link

Patch #5899

closed

Display user's gravatar when editing profile

Added by Jean-Baptiste Barth over 14 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
UI
Target version:
4.1.0
Start date:
2010-07-18
Due date:
% Done:

0%

Estimated time:

Description

See screenshot and patch attached, let me know what you think.

Files

Download all files
5899_git.diff (1001 Bytes) 5899_git.diff Jean-Baptiste Barth, 2010-07-18 16:28
gravatar_users_edit.png (23.5 KB) gravatar_users_edit.png Jean-Baptiste Barth, 2010-07-18 16:28
5899-20190513@2x.png (22.4 KB) 5899-20190513@2x.png Go MAEDA, 2019-05-12 18:28
5899-show-gravatar.patch (1.11 KB) 5899-show-gravatar.patch Go MAEDA, 2019-05-12 18:30

Related issues

Related to Redmine - Defect #33355: TypeError when attempting to update a user with a blank email addressClosedGo MAEDA

Actions
Blocked by Redmine - Patch #31391: Small refactorization of avatar methodsClosedGo MAEDA

Actions
Actions
Copy link
 #1

Updated by Go MAEDA over 5 years ago

Here is a completely rewritten patch for the latest trunk. Unfortunately, the patch 5899_git.diff is no longer applicable to the trunk.

Actions
Copy link
 #2

Updated by Go MAEDA over 5 years ago

  • Target version set to 4.1.0

Setting the target version to 4.1.0.

Actions
Copy link
 #3

Updated by Marius BĂLTEANU over 5 years ago

Go MAEDA wrote:

Setting the target version to 4.1.0.

Please wait few days before committing this because I've a patch that refactors a little bit the existing methods related to gravatar. I'll update your patch after that.

Actions
Copy link
 #4

Updated by Go MAEDA over 5 years ago

  • Assignee set to Marius BĂLTEANU

Marius BALTEANU wrote:

Please wait few days before committing this because I've a patch that refactors a little bit the existing methods related to gravatar. I'll update your patch after that.

Thanks. I am looking forward to it!

Actions
Copy link
 #5

Updated by Marius BĂLTEANU over 5 years ago

  • Assignee changed from Marius BĂLTEANU to Go MAEDA

Go MAEDA wrote:

Thanks. I am looking forward to it!

I've posted the patch.

Actions
Copy link
 #6

Updated by Go MAEDA over 5 years ago

  • Assignee changed from Go MAEDA to Marius BĂLTEANU

Marius, could you attach the patch?

Actions
Copy link
 #7

Updated by Marius BĂLTEANU over 5 years ago

Go MAEDA wrote:

Marius, could you attach the patch?

Sorry, I referred to the patch from #31391. Your patch from note-1 is good enough, we should remove only the size from it.

Actions
Copy link
 #8

Updated by Go MAEDA over 5 years ago

  • Blocked by Patch #31391: Small refactorization of avatar methods added
Actions
Copy link
 #9

Updated by Go MAEDA over 5 years ago

  • Status changed from New to Closed
  • Assignee changed from Marius BĂLTEANU to Go MAEDA

Committed the patch.

Actions
Copy link
 #10

Updated by Go MAEDA about 4 years ago

  • Related to Defect #33355: TypeError when attempting to update a user with a blank email address added
Actions
Copy link

Also available in: Atom PDF