Defect #6256
Redmine considers non ASCII and UTF-16 text files as binary in SCM
| Status: | Closed | Start date: | 2010-08-31 | |
|---|---|---|---|---|
| Priority: | Low | Due date: | ||
| Assignee: |  Toshi MARUYAMA | % Done: | 0% | |
| Category: | SCM | |||
| Target version: | 1.2.0 | |||
| Resolution: | Fixed | Affected version: |
Description
If source file contains less than 30% of ascii symbols - redmine threats it as binary.
It's affected when browsing repository:
/projects/PROJECT/repository/entry/FILE
(redmine just starts downloading, not showing source file).
The problem is that redmine relies on string method http://apidock.com/ruby/String/is_binary_data%3F
I understand this is ruby problem, but redmine could do some more checks - at least check for BOM marks.
more information here:
Related issues
Associated revisions
scm: filesystem: add test of no extension file whose content is only ASCII can be showing (#6256).
scm: mercurial: add test of binary file should be force download in functional test (#6256).
scm: filesystem: update test repository for non ascii text files displaying (#6256).
scm: fix non ascii text files displaying (#6256).
scm: filesystem: add test for non ascii text file displaying (#6256).
scm: filesystem: add test for UTF-16 file displaying (#6256).
scm: filesystem: add test for displaying file over max size limit (#6256).
scm: filesystem: increase non ascii contents ratio of test repository (#6256).
History
#1
Updated by Toshi MARUYAMA over 9 years ago
- Category set to SCM
- Status changed from New to 7
- Assignee set to Toshi MARUYAMA
#2
Updated by Toshi MARUYAMA over 9 years ago
- Subject changed from Redmine considers some not-ascii text files as binary to Redmine considers some not-ascii text files as binary in SCM
#3
Updated by Toshi MARUYAMA over 9 years ago
- Status changed from 7 to Closed
- Target version set to 1.2.0
- Resolution set to Fixed
I finished implementing until r5211.
#4
Updated by Toshi MARUYAMA over 9 years ago
- Subject changed from Redmine considers some not-ascii text files as binary in SCM to Redmine considers some not-ascii and UTF-16 text files as binary in SCM
#5
Updated by Toshi MARUYAMA over 9 years ago
- Subject changed from Redmine considers some not-ascii and UTF-16 text files as binary in SCM to Redmine considers non ASCII and UTF-16 text files as binary in SCM
#6
Updated by Toshi MARUYAMA over 3 years ago
- Description updated (diff)