Feature #4477
closedUse mime types in downloading from repository
0%
Description
Ok, so appart from the export:
links in "wiki" fields looking ugly (are there plans to make them show either only the filename or even make the links "configurable" like http links?), I had a user asking if there was a way to make the pdfs he had in the repo be shown in the browser instead of force-downloading them.
I have whipped up a small patch (somewhat looked off of the mimetype-fu plugin) that guesses the mime-type of a file according to its extension and Mime::Type
and sets the disposition to inline to make browsers show them instead of downloading them. The patch is attached, but it changes the behavior of the "raw
" download action also used by the download-Link in the repository tab.
That brings us to the discussion if the "raw
" Links should be changed, or if an extra action, say show
, should be configured, but the changes to the patch should be quite straightforward.
Last but not least: there are only a very few mime types defined in redmine at the moment, one source for some more could e.g. be this list from the mimetype-fu plugin.
Files
Related issues
Updated by Andrea Campi almost 15 years ago
+1 for the concept (although I haven't tried out the attached patch).
Updated by Toshi MARUYAMA almost 14 years ago
- Tracker changed from Patch to Feature
Updated by Toshi MARUYAMA almost 14 years ago
- Subject changed from Make export show repository files instead of forcing download to Use mime types in downloading from repository
Updated by Toshi MARUYAMA almost 14 years ago
- Status changed from New to Closed
- Target version set to 1.2.0
- Resolution set to Fixed
Updated by Toshi MARUYAMA almost 14 years ago
AttachmentsController uses "inline" for only images.
See source:tags/1.1.2/app/controllers/attachments_controller.rb#L43.