Project

General

Profile

Actions

Feature #2209

closed

MIME type support for repository Entries

Added by Vincent Castellano over 15 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
SCM
Target version:
-
Start date:
2008-11-17
Due date:
% Done:

70%

Estimated time:
Resolution:
Fixed

Description

I didn't like that images didn't just load in the browser that were in a repository, and felt there should be some MIME support, so I gave it a shot. I think it works for any files (with MIME type or not, which just defaults to the old behavior). I don't know the Redmine code base well, and I'm not a Ruby programmer, so it was a quick attempt.


Files

MimeType.patch (1.02 KB) MimeType.patch Vincent Castellano, 2008-11-17 20:56
MimeType.patch (1016 Bytes) MimeType.patch Cleaned up a bit. Vincent Castellano, 2008-11-17 20:57
dl_repo_files_with_MimeType_r2823.patch (944 Bytes) dl_repo_files_with_MimeType_r2823.patch Chris Grieger, 2009-07-18 18:16

Related issues

Related to Redmine - Feature #4477: Use mime types in downloading from repositoryClosed2009-12-23

Actions
Related to Redmine - Defect #6256: Redmine considers non ASCII and UTF-16 text files as binary in SCMClosedToshi MARUYAMA2010-08-31

Actions
Related to Redmine - Patch #3770: text/html documents force currently firefox to open download dialogClosed2009-08-23

Actions
Related to Redmine - Feature #6374: File raw view modeClosedToshi MARUYAMA2010-09-12

Actions
Related to Redmine - Feature #5055: Set mime-type in response when downloading repository filesClosedToshi MARUYAMA2010-03-11

Actions
Related to Redmine - Defect #6370: UTF-8 BOM only partially hiddenClosed2010-09-12

Actions
Related to Redmine - Feature #4577: convert text file attached an issue to utf-8.Closed2010-01-14

Actions
Actions #2

Updated by Chris Cummer over 15 years ago

A slight fix: I think line #125 should read:

send_data @content, :filename => fn, :type => type, :disposition => 'inline'

rather than:

send_data @content, :filename => fn, :type => type, => 'inline'
Actions #3

Updated by Patrick Hurrelmann over 15 years ago

+1, I like it very much. It keeps annoying me that files won't open in the browser even if the mime-type in the repository are set properly.

Actions #4

Updated by Ammler _ over 14 years ago

+1

Actions #6

Updated by Toshi MARUYAMA almost 13 years ago

  • Category set to SCM
Actions #7

Updated by Toshi MARUYAMA almost 13 years ago

  • Status changed from New to 7
  • Assignee set to Toshi MARUYAMA
Actions #8

Updated by Toshi MARUYAMA almost 13 years ago

  • Tracker changed from Patch to Feature
Actions #9

Updated by Toshi MARUYAMA almost 13 years ago

  • % Done changed from 0 to 70

As I described at #4477, I implemented this feature at r5210.
I don't know whether "inline" needs or not.

Actions #10

Updated by Jean-Philippe Lang about 11 years ago

  • Status changed from 7 to New
Actions #11

Updated by Toshi MARUYAMA about 11 years ago

  • Assignee deleted (Toshi MARUYAMA)
Actions #12

Updated by Go MAEDA about 1 year ago

  • Resolution set to Fixed

The request to display repository images inline was implemented in #10362 and #22058.

Actions #13

Updated by Go MAEDA about 1 year ago

  • Status changed from New to Closed
Actions

Also available in: Atom PDF