Actions
Defect #7134
closedis_binary_data uses wrong heuristic to decide if a string is binary
Status:
Closed
Priority:
Low
Assignee:
-
Category:
SCM
Target version:
-
Start date:
2010-12-19
Due date:
% Done:
0%
Estimated time:
Resolution:
Duplicate
Affected version:
Description
The is_binary_data method, used in repositories_controller.rb#124, is :
def is_binary_data? ( self.count( "^ -~", "^\r\n" ) / self.size > 0.3 || self.count( "\x00" ) > 0 ) unless empty? end
Applied to the attached file :
str='' File.open("test_color.sh", "r") { |f| str = f.read } (str.count("^ -~", "^\r\n") +0.0)/ str.length => 0.311345646437995
Which clearly is not < 0.3, so that file is downloaded instead of being displayed,
when one want to view it.
Files
Related issues
Actions