Project

General

Profile

Actions

Feature #7747

open

Add capability to ask\accept\reject review of patches (flag support on attachments)

Added by pasquale [:dedalus] about 13 years ago. Updated about 13 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Issues workflow
Target version:
-
Start date:
2011-03-01
Due date:
% Done:

0%

Estimated time:
Resolution:

Description

In bugzilla, we can ask for reviewing as patch: generally speaking an attachment can flag as "patch" and in this case the engine enable a flag to ask a review to project owner.
The project owner can reject the patch (review-) or approve the patch (review+).
It's great if redmine could be this in some way: add flag to attachment to make attachment "patch" and enable for "patch" flags to ask\accept\reject reviews


Files

Immagine.png (19.3 KB) Immagine.png bugzilla in action pasquale [:dedalus], 2011-03-15 08:52

Related issues

Related to Redmine - Patch #2525: Redmine management of Git repositoriesNew2009-01-18

Actions
Related to Redmine - Feature #469: Code Review/Approve workflow?Closed

Actions
Related to Redmine - Feature #2048: Code Review ModuleNew2008-10-18

Actions
Actions #1

Updated by Etienne Massip about 13 years ago

  • Category set to SCM

A la Gerrit / Gitosis ?

Actions #2

Updated by pasquale [:dedalus] about 13 years ago

Etienne Massip wrote:

A la Gerrit / Gitosis ?

I dont know well git behavior.
Surely my english don't help you( :-) ) : see an example on
https://bugzilla.mozilla.org/show_bug.cgi?id=468808

Actions #3

Updated by Etienne Massip about 13 years ago

  • Subject changed from Add capability to ask\accept\reject review of patches to Add capability to ask\accept\reject review of patches (flag support on attachments)
Actions #4

Updated by pasquale [:dedalus] about 13 years ago

I think that in a production environment this is an essential feature: if I'm the owner of a project and some collegue create a patch, it's very important to comunicate with him with flag: review+, riview- (of patch).

Priority should be High and not Normal

Actions #5

Updated by pasquale [:dedalus] about 13 years ago

xref bug #469 and bug #2048

Actions #6

Updated by pasquale [:dedalus] about 13 years ago

attached example screenshot

Actions #7

Updated by Toshi MARUYAMA about 13 years ago

  • Category changed from SCM to Issues workflow
Actions

Also available in: Atom PDF