Actions
Defect #9377
open<br /> is not inserted before macro in Wiki
Status:
New
Priority:
Normal
Assignee:
-
Category:
Text formatting
Target version:
-
Start date:
2011-10-05
Due date:
% Done:
0%
Estimated time:
Resolution:
Affected version:
Description
<br /> tag is not inserted before macros in Wiki.
For example,
abc !{{hello_world}}
should be converted to
<p>abc<br />Hello world! Object: Journal, Called with no argument.</p>
However, it is converted to
<p>abc Hello world! Object: Journal, Called with no argument.</p>
Detail and cause:
<br /> in Wiki is inserted by hard_break
method in "lib/redmine/wiki_formatting/textile/formatter.rb".
This method replaces "\n" with "<br />" as follows:
text.gsub!( /(.)\n(?!\n|\Z| *([#*=]+(\s|$)|[{|]))/, "\\1<br />" ) if hard_breaks
It seems that "[{|]" prevents insertion of "<br />" before CSS style and in table, because CSS style in Wiki starts with "{" and cells of table are separated by "|".
Macros in Wiki also start with double "{"s, so "<br />" is not inserted before macros.
I think that hard_break
method should be
text.gsub!( /(.)\n(?!\n|\Z| *([#*=]+(\s|$)|\{[^{]|\|))/, "\\1<br />" ) if hard_breaks
to replace "\n" before macros. Environment:
- Redmine version 1.2.1
- Ruby version 1.8.7 (patch 174)
- Rails version 2.3.5
Files
Actions