Project

General

Profile

Actions

Defect #9405

closed

Any user with :log_time permission can edit time entries via context menu

Defect #9405: Any user with :log_time permission can edit time entries via context menu

Added by Jevgen Gyrynovych about 15 years ago. Updated almost 15 years ago.

Status:
Closed
Priority:
High
Category:
Time tracking
Target version:
Resolution:
Fixed
Affected version:

Description

In Redmine 1.2.0 or later any user can edit any time entries via context menu.
Example url: http://redmine/projects/testproject/time_entries and click right mouse button on any time entries.
img1.png - user have permission to edit any time entries
img2-4.png - user edit time entries without permission on it.

As you can see, user with permissions have icons for edit time report, but user without permissions can do this via context menu anyway.

PS: I set high priority to ticket. I think, this serious defect?


Files

img1.png (16.7 KB) img1.png Jevgen Gyrynovych, 2011-10-11 19:31
img2.png (13.6 KB) img2.png Jevgen Gyrynovych, 2011-10-11 19:31
img3.png (16.9 KB) img3.png Jevgen Gyrynovych, 2011-10-11 19:31
img4.png (16.4 KB) img4.png Jevgen Gyrynovych, 2011-10-11 19:31
redmine.rb.patch (1.16 KB) redmine.rb.patch Jevgen Gyrynovych, 2011-11-25 15:40

Related issues 1 (0 open — 1 closed)

Related to Redmine - Feature #7996: Bulk edit and context menu for time entriesClosedToshi MARUYAMAActions

Updated by Etienne Massip about 15 years ago Actions #1

  • Category set to Time tracking

Updated by Mischa The Evil about 15 years ago Actions #2

  • Priority changed from High to Normal

I'm not able to reproduce this issue with source:/trunk@7623.

Are you sure that you were not testing this with an account configured as an administrator?

Updated by Toshi MARUYAMA about 15 years ago Actions #3

  • Priority changed from Normal to High

I can reproduce.

Updated by Toshi MARUYAMA about 15 years ago Actions #4

This line has a bug.
source:trunk/app/controllers/context_menus_controller.rb#L54

Updated by Etienne Massip about 15 years ago Actions #5

  • Target version set to Candidate for next minor release

Updated by Mischa The Evil about 15 years ago Actions #6

Ahh, I see... Thanks for your clarification on this Toshi. I was testing with an account that did not had the :log_time permission at all :-/

Updated by Jean-Philippe Lang about 15 years ago Actions #7

  • Target version changed from Candidate for next minor release to 1.2.3

Updated by Jean-Philippe Lang almost 15 years ago Actions #8

  • Status changed from New to Resolved

See related commits.

Updated by Jean-Philippe Lang almost 15 years ago Actions #9

  • Assignee set to Jean-Philippe Lang

Updated by Jevgen Gyrynovych almost 15 years ago Actions #10

Now it work fine. Thanks.

Updated by Jevgen Gyrynovych almost 15 years ago Actions #11

I find some problem after apply the patch - when user tried to update ticket(e.g. nuber_of_ticket/edit), he dont have access to "Log time".
It fix that problem.

Updated by Jean-Philippe Lang almost 15 years ago Actions #12

I don't know what this patch is supposed to fix but :log_time should not allow the user to edit time entries.
I fixed a last point in r7924 which may be related to your fix.

Updated by Jean-Philippe Lang almost 15 years ago Actions #13

  • Subject changed from any user can edit time entries via context menu to Any user with :log_time permission can edit time entries via context menu
  • Status changed from Resolved to Closed
  • Resolution set to Fixed

Merged in 1.2-stable.

Actions

Also available in: PDF Atom