Feature #9720

Add note number for single issue's PDF

Added by Akiko Takano almost 10 years ago. Updated almost 10 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Toshi MARUYAMA% Done:

0%

Category:PDF export
Target version:1.3.0
Resolution:Fixed

Description

Please add note number for single issue not only for html but also PDF.

pdf.diff Magnifier - diff for changeset 6313:81b83bbb8e6d (1.13 KB) Akiko Takano, 2011-12-05 04:01

r8090.diff Magnifier (692 Bytes) Toshi MARUYAMA, 2011-12-05 09:58

Associated revisions

Revision 8090
Added by Toshi MARUYAMA almost 10 years ago

pdf: add note number for single issue's PDF (#9720)

Contributed by Akiko T.

Revision 8099
Added by Toshi MARUYAMA almost 10 years ago

pdf: move note number to the head of line for single issue's PDF (#9720)

History

#1 Updated by Toshi MARUYAMA almost 10 years ago

  • Assignee set to Toshi MARUYAMA
  • Target version set to 1.3.0

#2 Updated by Toshi MARUYAMA almost 10 years ago

  • Target version deleted (1.3.0)

#3 Updated by Toshi MARUYAMA almost 10 years ago

  • Status changed from New to Closed
  • Target version set to 1.3.0
  • Resolution set to Fixed

Committed in trunk r8090 and 1.3-stable r8091, thanks.

#4 Updated by Etienne Massip almost 10 years ago

Having the note number right after the user name is not very readable, it feels like the note is referring to the user; what would you think of inserting it at the begin of the line or at least add a hyphen to separate username and note#?

It's fine in HTML since the note is at the end of the line.

#5 Updated by Toshi MARUYAMA almost 10 years ago

This is a patch to move note number at beginning line.
I remove "note", because there is no "note" translation.

#6 Updated by Etienne Massip almost 10 years ago

I tested 2 different versions of your patch:

  • #1 <date and time> - <username>
  • #1 - <date and time> - <username>

As a personal POV, I'd rather use the second one since, in the first one, the separation between note# last digit and date first digit is not obvious.

#7 Updated by Akiko Takano almost 10 years ago

MARUYAMA-san, Thanks for your work!

#8 Updated by Toshi MARUYAMA almost 10 years ago

I committed "#1 - <date and time> - <username>" in trunk r8099 and 1.3-stable r8100.

Also available in: Atom PDF