Redmine

CS Wong wrote:

What I've done is

1. Enabled plugin
2. Enabled code review module for my project (I can see the Code Review tab in project settings)

If you run Redmine in development mode, change to production mode.
Then you will see Code Review tab in project settings.
And specify the tracker for review.

Thanks.

G'day Haru,

Great plugin. My company intends to use it.

I see from previous message threads that you were considering a "My Reviews" page; I was wondering if you could tell me what this would involve?

A grouping of files to be reviewed would also be handy for our workflow; not sure if you have considered this.

Many thanks,
Brendan

Haru Iida wrote:

I released a Code Review Plugin 0.2.3 Released.

Again no tag ;-)

Greets
Marcel

Managed to get Code Review working. Realized that previously I couldn't see the Review links because of how I entered the repository page.

• http://mydomain.com/projects/myproject/repository/revisions/13207/entry/mypage.html - I will see "Review" link
• http://mydomain.com/projects/myproject/repository/entry/mypage.html - I will not see "Review" link

Is there a reason why it behaves differently?

Thanks,
Wong

What happened after 0.2.1 ?
0.2.1 works fine, but when I install 0.2.2 or 0.2.3 - Redmine breaks with an error:

Status: 500 Internal Server Error Content-Type: text/html
500 Internal Server Error

Denis Tomashenko wrote:

What happened after 0.2.1 ?
0.2.1 works fine, but when I install 0.2.2 or 0.2.3 - Redmine breaks with an error:
[...]What I need to do?

Hi Denis.
Any stack trace in your production.log?

CS Wong wrote:

Managed to get Code Review working. Realized that previously I couldn't see the Review links because of how I entered the repository page.

For e.g.:

• http://mydomain.com/projects/myproject/repository/revisions/13207/entry/mypage.html - I will see "Review" link
• http://mydomain.com/projects/myproject/repository/entry/mypage.html - I will not see "Review" link

Is there a reason why it behaves differently?

Because second one is not specified revision. A head code changes day by day. So you can't add review to it.

Thanks.

Brendan D'Arcy wrote:

I see from previous message threads that you were considering a "My Reviews" page; I was wondering if you could tell me what this would involve?

Hi Brendan.

I had considered certainly so before. But since 2.0, review is link to issue. and your issues are displayed in "My Page". So I think I don't need to implement it now.

Thanks.

Very true, thanks for the clarification!

Haru Iida wrote:

CS Wong wrote:

Managed to get Code Review working. Realized that previously I couldn't see the Review links because of how I entered the repository page.

For e.g.:

• http://mydomain.com/projects/myproject/repository/revisions/13207/entry/mypage.html - I will see "Review" link
• http://mydomain.com/projects/myproject/repository/entry/mypage.html - I will not see "Review" link

Is there a reason why it behaves differently?

Because second one is not specified revision. A head code changes day by day. So you can't add review to it.

Thanks.

G'day Haru,

Haru Iida wrote:

I had considered certainly so before. But since 2.0, review is link to issue. and your issues are displayed in "My Page". So I think I don't need to implement it now.

Makes sense.

Have you considered having a grouping of candidate files subject to review? Something a bit more automated than sending files and revision numbers in an email would be nice.

Thanks again,
Brendan

Brendan D'Arcy wrote:

Have you considered having a grouping of candidate files subject to review? Something a bit more automated than sending files and revision numbers in an email would be nice.

+1

Haru Iida wrote:

Hi Denis.
Any stack trace in your production.log?

Stack trace like above:

/!\ FAILSAFE /!\  Wed Sep 09 16:03:33 +0300 2009
  Status: 500 Internal Server Error
  A secret is required to generate an integrity hash for cookie session data. Use config.action_controller.session = { :session_key => "_myapp_session", :secret => "some secret phrase of at least 30 characters" } in config/environment.rb
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/session/cookie_store.rb:91:in `ensure_secret_secure'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/session/cookie_store.rb:59:in `initialize'
    C:/Program Files/Redmine/ruby/lib/ruby/1.8/cgi/session.rb:273:in `new'
    C:/Program Files/Redmine/ruby/lib/ruby/1.8/cgi/session.rb:273:in `initialize_without_cgi_reader'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/cgi_ext/session.rb:19:in `initialize'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/cgi_process.rb:94:in `new'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/cgi_process.rb:94:in `session'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/cgi_process.rb:130:in `stale_session_check!'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/cgi_process.rb:78:in `session'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/base.rb:1205:in `assign_shortcuts_without_flash'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/flash.rb:166:in `assign_shortcuts'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/base.rb:519:in `process_without_filters'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/filters.rb:606:in `process_without_session_management_support'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/session_management.rb:134:in `process'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/base.rb:392:in `process'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/dispatcher.rb:183:in `handle_request'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/dispatcher.rb:110:in `dispatch_unlocked'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/dispatcher.rb:123:in `dispatch'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/dispatcher.rb:122:in `synchronize'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/dispatcher.rb:122:in `dispatch'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/dispatcher.rb:132:in `dispatch_cgi'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/dispatcher.rb:39:in `dispatch'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel/rails.rb:76:in `process'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel/rails.rb:74:in `synchronize'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel/rails.rb:74:in `process'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel.rb:159:in `process_client'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel.rb:158:in `each'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel.rb:158:in `process_client'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel.rb:285:in `run'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel.rb:285:in `initialize'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel.rb:285:in `new'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel.rb:285:in `run'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel.rb:268:in `initialize'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel.rb:268:in `new'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel.rb:268:in `run'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel/configurator.rb:282:in `run'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel/configurator.rb:281:in `each'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel/configurator.rb:281:in `run'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/mongrel_rails:128:in `run'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/../lib/mongrel/command.rb:212:in `run'
    C:/Program Files/Redmine/ruby/lib/ruby/gems/1.8/gems/mongrel-1.1.3-x86-mswin32/bin/mongrel_rails:281
    C:/Program Files/Redmine/ruby/bin/mongrel_rails:19:in `load'
    C:/Program Files/Redmine/ruby/bin/mongrel_rails:19

Redmine in production mode.
Solutions to resolve this error I not found in previous posts.
How to fix? Please help!

Denis Tomashenko wrote:

Haru Iida wrote:

Hi Denis.
Any stack trace in your production.log?

Stack trace like above:
[...]

Redmine in production mode.
Solutions to resolve this error I not found in previous posts.
How to fix? Please help!

Maybe your problem is same case with this one.
http://www.redmine.org/boards/3/topics/7130#message-8379

After upgrading to latest trunk (r2888), db:migrate fails when code review is installed.

Turns out we need to edit the following file in code review:

redmine_code_review/lib/code_review_repositories_controller_patch.rb

and amend line 22:

require_dependency 'application_controller'

instead of

require_dependency 'application'

Code Review Plugin 0.2.4 Released.
http://r-labs.googlecode.com/files/redmine_code_review-0.2.4.zip

This is bug fix only.

• Compatible with current trunk redmine. Thanks, CS Wong.
• Sometimes review addition fails on redmine 0.8.5.
• Can't display review summary when repository is git.

So how do you close a ticket without making a commit?

Sorry, ignore that question. Answered it myself.

I am having a problem installing version of the plugin later than 0.2.0. When I try to the plugin migration I get the error "uninitialized constant ApplicationHelper::GravatarHelper" I have Googled this but the only thing I find is either http://www.redmine.org/boards/2/topics/6989 or references to topic 6989. Unfortunately, there is no solution listed. I pretty new to Rails and Redmine. I have tried figuring this out on my own. I have found GravatarHelper in the gravatar plugin directory and I see were there is some sort of include for it in the source file for ApplicationHelper but I can't figure out why it would be uninitialized.

Thanks

Code Review Plugin 0.2.5 was released.

http://r-labs.googlecode.com/files/redmine_code_review-0.2.5.zip

Features:

• If the revision mentions one or more issues, the code review issue relates to them. or blocks them. It's configurable.
  
• Now you can jump from head code to revision view. So you can add review to head code easyer.
• When you create a new review issue, you can assign it to the member who did not commit the code.

Fixed bug:

• Exception occurs when you create new review with no input.

Regards.

Hello, I tested trunk HEAD (r2823), but it looks like your plugin failed to work with, maybe something with rails 2.3.4?

How can I see, which trunk revision you used to test it?

Greets and Thanks
Marcel

Hi, Marcel.

Marcel Gmür wrote:

Hello, I tested trunk HEAD (r2823), but it looks like your plugin failed to work with, maybe something with rails 2.3.4?

How can I see, which trunk revision you used to test it?

I tested with Redmine trunk r2924 and it works.

What is the "failed" means of? Did you find any errors? I need more information.

Thanks.

Code Review Plugin 0.2.6 was released.

http://r-labs.googlecode.com/files/redmine_code_review-0.2.6.zip

feature:

Now you can add review to the patches that attached to issues.

Thanks.

Haru Iida wrote:

I tested with Redmine trunk r2924 and it works.

I meant r2923, of course

What is the "failed" means of? Did you find any errors? I need more information.

I get the following error msg, if I call the repository tab:
http://pastebin.ca/1622213

(no issue without your plugin)

Greets
Marcel

Hi Marcel.

If your redmine runs on development mode, this error happens. This plugin works only on production mode.

Thanks.

Does 0.2.6 work with Redmine 0.8.5? Plugin installation is fine, but i can not add review at all.