Redmine

Haru Iida wrote:

Code Review Plugin 0.2.6 was released.

http://r-labs.googlecode.com/files/redmine_code_review-0.2.6.zip

feature:

Now you can add review to the patches that attached to issues.

Thanks.

I am getting the following error when viewing a file at a revision/changeset number where the file was not included in the revision/changeset directly (e.g., svn copy):

change not found.
@path = '/projects/projectname1/branches/branchname1/app/models/model_name.rb'
@changeset = #<Changeset:0xb64f7714>
@rev = 2963

• '/projects/projectname1/branches/branchname1'

URL path is: https://host1/redmine/projects/projectname1/repository/revisions/2963/entry/projects/projectname1/branches/branchname1/app/models/model_name.rb

Hi Jackey.

Jackey Yang wrote:

Does 0.2.6 work with Redmine 0.8.5? Plugin installation is fine, but i can not add review at all.

I tested both 0.8.5 and trunk. Do you have any stacktraces or error messages?

Hi Ray.

Ray Q wrote:

I am getting the following error when viewing a file at a revision/changeset number where the file was not included in the revision/changeset directly (e.g., svn copy):

Thanks. I will fix it in next release.

I did install 0.2.6 successfully, how do I get it work in my browser? I am using LDAP for SVN authentication.
I also setup permission, but i can not input a code review at all.

Hi.

Jackey Yang wrote:

I did install 0.2.6 successfully, how do I get it work in my browser? I am using LDAP for SVN authentication.
I also setup permission, but i can not input a code review at all.

At first, you must select the tracker for the review Issues.
Go to the project setting page and open the code review tab, then you will find it.

Thanks.

Hey,
I've been fiddling with your code review tool. It's quite slick. Good work! However, my co-workers and I have found a strange bug: we can add code reviews to some projects, but not others. The link to add a review appears for only some of our projects, even though it's enabled for all of them.

Any ideas on what might cause it to not show up for some?

Hi Omar Zakaria.

Maybe you don't select the tracker of review issue for the projects that you couldn't add review. Please select it at the Code Review setting page in the project setting menu.

I know it's difficult to judge whether you did it or not. I will consider a better way.

Regards.

Hi Haru Iida,
I think I just discovered what is happening. The annotate link appeared as soon as I checked in some new code. I think you're looking for a diff set before you allow people to make annotations.

In any case, it seems to be working fine, now. Thanks for the work!

Hi Haru Iida,

Firstly, thank you for developing a great plugin. You've certainly made many people's lives easier. :)

I'm trying to evaluate this plugin for my project (tested on 0.2.6); so far everything works great, except these 2 problems:

-- When I installed the plugin, while migrating the database using rake, i've encountered this error: "This application has failed to start because CORE_RL_magick_.dll was not found.", and then "This application has failed to start because MYSQLDB.dll was not found." (can't rmb the exact name of the dll). My Redmine installation is using Bitnami stack.

But I ignored the errors and went on with the db migration and it still works fine for me. Do you have any idea what was the problem? I'm a complete newbie to ruby on rails.

-- At the moment, I can only access the Code Review tab if i'm the administrator. I have tried to create a new user, and whenever I assign this user as a redmine administrator then the tab appears; otherwise it's not showing. Have you encountered this before?

Thanks a lot for your time. :)

Hi Ryan Phung,

About your first question, sorry, I have no idea.

About second one, I think you did not set the permissions.

1. Go to 'Administration' -> 'Roles and permissions'
2. Select the role which you want to permit to use code review.
3. Set the permissons to the role you selected.

Regards.

Hi Haru Iida,

Thank you; that does it for me! I didn't realize that Redmine allows such configurations :)

Warm Regards,
- Ryan

Haru Iida wrote:

Code Review Plugin 0.2.6 was released.

http://r-labs.googlecode.com/files/redmine_code_review-0.2.6.zip

feature:

Now you can add review to the patches that attached to issues.

Thanks.

Haru,
This plugin looks great. However, I am not seeing the Code Review Tab in Project Settings as you describe. I enable the Code Review module, but no additional tab appears. What does happen however is the following error when I view any issue details. As soon as I disable the Code Review Module checkbox, all is well again.

NoMethodError in Issues#show
Showing issues/show.rhtml where line #57 raised:
undefined method `code_review' for #<Issue:0xb6601e0c>

Extracted source (around line #57):
---
54: <%end
55: end >
56: </tr>
57: <= call_hook(:view_issues_show_details_bottom, :issue => @issue) %>
58: </table>
59: <hr />
60:

FULL TRACE:
----
usr/lib/ruby/gems/1.8/gems/activerecord-2.1.2/lib/active_record/attribute_methods.rb:256:in `method_missing'
vendor/plugins/redmine_code_review/lib/code_review_issue_hooks.rb:31:in `view_issues_show_details_bottom'
lib/redmine/hook.rb:63:in `send'
lib/redmine/hook.rb:63:in `call_hook'
lib/redmine/hook.rb:63:in `each'
lib/redmine/hook.rb:63:in `call_hook'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.1.2/lib/active_support/core_ext/object/misc.rb:28:in `returning'
lib/redmine/hook.rb:60:in `call_hook'
lib/redmine/hook.rb:144:in `call_hook'
app/views/issues/show.rhtml:57:in `_run_erb_47app47views47issues47show46rhtml'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_view/base.rb:342:in `send'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_view/base.rb:342:in `execute'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_view/template_handlers/compilable.rb:29:in `send'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_view/template_handlers/compilable.rb:29:in `render'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_view/template.rb:35:in `render'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_view/template.rb:22:in `render_template'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_view/base.rb:248:in `render_file'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:1112:in `render_for_file'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:872:in `render_with_no_layout'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/layout.rb:251:in `render_without_benchmark'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/benchmarking.rb:51:in `render'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.1.2/lib/active_support/core_ext/benchmark.rb:8:in `realtime'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/benchmarking.rb:51:in `render'
app/controllers/issues_controller.rb:106:in `show'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/mime_responds.rb:131:in `call'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/mime_responds.rb:131:in `custom'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/mime_responds.rb:160:in `call'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/mime_responds.rb:160:in `respond'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/mime_responds.rb:154:in `each'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/mime_responds.rb:154:in `respond'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/mime_responds.rb:107:in `respond_to'
app/controllers/issues_controller.rb:105:in `show'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:1166:in `send'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:1166:in `perform_action_without_filters'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/filters.rb:579:in `call_filters'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/filters.rb:572:in `perform_action_without_benchmark'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/benchmarking.rb:68:in `perform_action_without_rescue'
/usr/lib/ruby/1.8/benchmark.rb:293:in `measure'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/benchmarking.rb:68:in `perform_action_without_rescue'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/rescue.rb:201:in `perform_action_without_caching'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/caching/sql_cache.rb:13:in `perform_action'
/usr/lib/ruby/gems/1.8/gems/activerecord-2.1.2/lib/active_record/connection_adapters/abstract/query_cache.rb:33:in `cache'
/usr/lib/ruby/gems/1.8/gems/activerecord-2.1.2/lib/active_record/query_cache.rb:8:in `cache'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/caching/sql_cache.rb:12:in `perform_action'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:529:in `send'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:529:in `process_without_filters'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/filters.rb:568:in `process_without_session_management_support'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/session_management.rb:130:in `process'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:389:in `process'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:149:in `handle_request'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:107:in `dispatch'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:104:in `synchronize'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:104:in `dispatch'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:120:in `dispatch_cgi'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:35:in `dispatch'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/rails.rb:76:in `process'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/rails.rb:74:in `synchronize'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/rails.rb:74:in `process'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:159:in `process_client'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:in `each'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:in `process_client'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `initialize'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `new'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `initialize'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `new'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/configurator.rb:282:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/configurator.rb:281:in `each'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/configurator.rb:281:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/mongrel_rails:128:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/command.rb:212:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/mongrel_rails:281
/usr/bin/mongrel_rails:19:in `load'
/usr/bin/mongrel_rails:19

SESSION DUMP:
---
:query:
:project_id: 14
:filters:
status_id:
:operator: o
:values:
- ""
:user_id: 3
adminprojects_sort:
:key: name
:order: asc
issuesindex_sort:
:key: id
:order: desc
flash: !map:ActionController::Flash::FlashHash {}

Hi Mark P.

This error occurs if your Redmine runs in development mode.
This plugin works only on production mode.

Thanks.

I suspected this was the problem. Perhaps you could assist me in this regard. I have separate development and production servers of Redmine. On the dev box, I changed the database.yml, environment.yml, and production.yml such that it appears like production. When I ran rake db:migrate_plugins RAILS_ENV=production, it finished without errors.

What else can I do to "trick" your plugin into thinking my dev is production? I cannot implement this change directly into prod without evaluating it first. Any assistance you could provide would be helpful.
Thank you,
Mark

Hi Mark P.

Try this one.
http://r-labs.googlecode.com/files/redmine_code_review-0.2.7-beta.zip

It works with development mode.
Except one thing: Code Review setting menu appears only once immediately after the Redmine started.

Regards.

Is latest version of Code Review plugin (0.2.9 currently) compatible with Redmine 0.8.5 Stable?
If not - could you give me an advice which version will be the best?

Thanks.

Hi Ivan Danilov.

I tested it with Redmine 0.8.6, 0.8.7 and trunk(3069).
And may be it works with 0.8.5.

Thanks.

When I have added new file to repository - there's no 'diff' link. And so, no way to do a review of new files. Am I able to fight it somehow? :)

Ooops, sorry, it was my fault.

File was encoded for some strange reason in UTF-16 and SVN didn't recognize it as text - instead property svn:mime-type="application/octet" was set. And that's because I can't review it :(

Ivan Danilov wrote:

When I have added new file to repository - there's no 'diff' link. And so, no way to do a review of new files. [...]

Starting from version 0.2.2 you can also add reviews through the view and annotate views, see http://www.redmine.org/boards/3/topics/7646#message-7881.

HTH...

I'll lock this topic to prevent further distinction of the forum messages in different threads.

New, updated thread where further discussion about the plugin is welcome can be found at http://www.redmine.org/boards/3/topics/9627.

 
Kind regards,

Mischa.