Actions
Feature #10314
closedMake the only enabled activity in a project the default one for time entry
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Description
Example: In administration, if we have 4 activities (A, B, C, D) and A by default,
If activity C is the only one we can set in a project, so when submitting time entry we have to choose C as activity although it is the only choice in the combobox.
The field is compulsory so it is disturbing to set C as activity wherever we input time.
Files
Updated by Bo Hansen over 12 years ago
I agree. Maybe the best solution would be to allow setting a default activity per project?
Here's a simple patch which removes blank field if only one activity is present:
diff --git a/app/helpers/timelog_helper.rb b/app/helpers/timelog_helper.rb index 6be6c58..04ac1bc 100644 --- a/app/helpers/timelog_helper.rb +++ b/app/helpers/timelog_helper.rb @@ -49,7 +49,8 @@ module TimelogHelper if time_entry && time_entry.activity && !time_entry.activity.active? collection << [ "--- #{l(:actionview_instancetag_blank_option)} ---", '' ] else - collection << [ "--- #{l(:actionview_instancetag_blank_option)} ---", '' ] unless activities.detect(&:is_default) + collection << [ "--- #{l(:actionview_instancetag_blank_option)} ---", '' ] unless activities.detect(&:is_default) || + activities.count == 1 end activities.each { |a| collection << [a.name, a.id] } collection
Updated by Etienne Massip over 12 years ago
- Category changed from Issues to Time tracking
Updated by Mizuki ISHIKAWA over 2 years ago
- File feature-10314.patch feature-10314.patch added
I have attached the patch.
Updated by Go MAEDA over 2 years ago
- File feature-10314-v2.patch feature-10314-v2.patch added
- Target version set to Candidate for next major release
Mizuki ISHIKAWA wrote:
I have attached the patch.
Thank you for posting the patch. I slightly updated it.
- Changed the method name of
TimeEntryActivity.chooseable_activities
toavailable_activities
- Fixed a RuboCop offense Layout/LineLength
- Changed the argument of method call at line 29 in
app/helpers/timelog_helper.rb
from@project
toproject
(I think this is a typo. Please review this change)
Updated by Go MAEDA over 2 years ago
- Target version changed from Candidate for next major release to 5.1.0
Setting the target version to 5.1.0.
Updated by Go MAEDA over 2 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you for your contribution.
Actions