Redmine

I confirm.

Environment:
  Redmine version                          2.3.0.stable
  Ruby version                             1.9.3 (i386-mingw32)
  Rails version                            3.2.13
  Environment                              production
  Database adapter                         Mysql2
Redmine plugins:
  clipboard_image_paste                    1.5
  projects_tree_view                       0.0.8
  redmine_apijs                            4.2.0
  redmine_code_review                      0.6.1
  redmine_didyoumean                       1.2.0
  redmine_favourite_projects               0.6
  redmine_information                      1.0.2
  redmine_issue_checklist                  2.0.5
  redmine_local_avatars                    0.1.1
  redmine_pastebin                         0.2.0
  redmine_plugin_views_revisions           0.0.1
  redmine_theme_changer                    0.1.0
  redmine_user_issues                      0.0.2
  redmine_wiki_gchart_formula              0.0.5
  redmine_xls_export                       0.2.1
  redmine_youtube                          0.0.1
  sidebar_hide                             0.0.2
  wiking                                   0.0.3

It reminds me to #12641 (r11551). I suggested at first a the patch containing the lines with ".ord.between?(128, 191)" but recognized later a much more elegant solution and added a second patch that just sets the encoding. The 2nd patch hasn't been taken. Why not simply setting the encoding?

Filou Centrinov wrote:

Why not simply setting the encoding?

Because tests fail on Ruby 1.8.7.

I cannot reproduce on ruby 1.8.7 (2012-10-12 patchlevel 371) [x86_64-linux].

$ irb
1.8.7 :001 > s = "abc" 
 => "abc" 
1.8.7 :002 > s[-1].ord
 => 99 
1.8.7 :003 > s = "日本語" 
 => "\346\227\245\346\234\254\350\252\236" 
1.8.7 :004 > s[-1].ord
 => 158 

"ending" is always negative value.
I think that I should correct it as follows.

--- unified_diff.rb_org 2013-07-25 20:57:37.000000000 +0900
+++ unified_diff.rb     2013-07-25 21:23:36.000000000 +0900
@@ -206,12 +206,12 @@
         end
         ending = -1
         while ending >= -(max - starting) && line_left[ending] == line_right[ending]
           ending -= 1
         end
-        if (! "".respond_to?(:force_encoding)) && ending > (-1 * line_left.size)
-          while line_left[ending].ord.between?(128, 191) && ending > -1
+        if (! "".respond_to?(:force_encoding))
+          while ending > (-1 * line_left.size) && line_left[ending].ord.between?(128, 191)
             ending -= 1
           end
         end
         unless starting == 0 && ending == -1
           [starting, ending]

Jun NAITOH wrote:

"ending" is always negative value.
I think that I should correct it as follows.

Could you give me examples or tests?

Jun NAITOH wrote:

Sorry, note-10 sample code has a problem.

I rewrote the code, and added test code.

Thanks.
I have created new issue #14562.