Project

General

Profile

Actions
Copy link

Defect #14798

closed

Wrong done_ratio calculation for parent with subtask having estimated_hours=0

Added by Daniel Felix over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Issues planning
Target version:
2.3.3
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Hi there,

this patch corrects a bug in the calculation of the done_ratio value in some edge case.

Ways to reproduce this bug:
  • Define a parent issue
  • Define two subissues on this parent issue
  • Set on one subissue estimated_hours to 0
  • Close subissue with no estimated_hours -> parent issue has done_ratio = 50%
  • Close subissue with estimated_hours set to zero value -> parent issue still has done_ratio = 50%

This patch solves this issue.

@Jean-Philippe: Maybe you or Toshi could take a look at this?

Best regards,
Daniel

Files

patch_done_ratio_on_zero_values.diff (805 Bytes) patch_done_ratio_on_zero_values.diff Daniel Felix, 2013-08-29 10:13
Actions
Copy link
 #1

Updated by Felix Schäfer over 11 years ago

We also stumbled on this at Planio, the proposed diff fixes the problem, thanks!

Actions
Copy link
 #2

Updated by Jean-Philippe Lang over 11 years ago

  • Tracker changed from Patch to Defect
  • Subject changed from Wrong done_ratio calculation on zero values in subissue. to Wrong done_ratio calculation for parent with subtask having estimated_hours=0
  • Status changed from New to Resolved
  • Target version set to 2.3.3
  • Resolution set to Fixed

Patch committed with a test, thanks for pointing this out.

Actions
Copy link
 #3

Updated by Jean-Philippe Lang over 11 years ago

  • Status changed from Resolved to Closed

Merged.

Actions
Copy link

Also available in: Atom PDF