Feature #14830
closed
REST API : Add support for attaching file to Wiki pages
Added by Michael Medin about 11 years ago.
Updated over 7 years ago.
Description
Currently (2.3.2) it is not possible (that I know of) to attach files to wiki pages.
AS a workaround i have attached all files to an arbitrary ticket instead which works but is pretty awkward.
It would be nice if it was possible to attach the file directly to the wikipage instead.
// Michael Medin
Files
Sorry, I forgot to mention I meant via the REST API.
- Subject changed from Add support for attaching file to WIKI pages to Add support for attaching file to WIKI pages by REST API
- Category changed from Rails support to REST API
Had the same problem here, the following patch make it working (I am not a ruby specialist, just took the snippet from the issue controller; normal upload and rest upload is then working):
Index: wiki_controller.rb
===================================================================
--- wiki_controller.rb (revision 14728)
+++ wiki_controller.rb (working copy)
@@ -152,7 +152,7 @@
@content.author = User.current
if @page.save_with_content(@content)
- attachments = Attachment.attach_files(@page, params[:attachments])
+ attachments = Attachment.attach_files(@page, params[:attachments] || (params[:wiki_page] && params[:wiki_page][:uploads]))
render_attachment_warning_if_needed(@page)
call_hook(:controller_wiki_edit_after_save, { :params => params, :page => @page})
Added this patch to the patch-queue #21066
- Related to Patch #21066: Enable adding attachments to wiki entries using the Rest-API added
- Has duplicate Feature #13843: Redmine API: can wiki pages contain uploads added
I added a test-case for Sven S.'s patch.
This patch workes fine under the latest trunk r15317.
I would be happy if I could see the feature in Redmine 3.3.0.
- Target version set to 3.3.0
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Committed, thanks. I've removed the test with the 'attachment' param as it's not supposed to be used with the API. Attachments should be added through the API with wiki_page[uploads].
- Subject changed from Add support for attaching file to WIKI pages by REST API to REST API : Add support for attaching file to Wiki pages
Michael Medin wrote:
Currently (2.3.2) it is not possible (that I know of) to attach files to wiki pages.
AS a workaround i have attached all files to an arbitrary ticket instead which works but is pretty awkward.
It would be nice if it was possible to attach the file directly to the wikipage instead.
// Michael Medin
I'm realy not clear about this feature.@Michael, Lang Can you explain more about it. How can i replay it ? I'm using v.3.2.6
Vu Anh wrote:
Michael Medin wrote:
Currently (2.3.2) it is not possible (that I know of) to attach files to wiki pages.
AS a workaround i have attached all files to an arbitrary ticket instead which works but is pretty awkward.
It would be nice if it was possible to attach the file directly to the wikipage instead.
// Michael Medin
I'm realy not clear about this feature.@Michael, Lang Can you explain more about it. How can i replay it ? I'm using v.3.2.6
This feature is included in Redmine 3.3.
Also available in: Atom
PDF