Deprecate and rename rss_* methods to atom_* methods
|Target version:||Candidate for next major release|
This issue is extracted from #13460-2 after 2.4 feature freeze.
Daniel Felix wrote in #13460-2 (note-2):
- File Attachment:functional_renaming_rss_to_atom.diff added
I'll provide two patches.
Number 2: functional renaming. Deprecation of old rss_* methods and redefining them as atom_* methods. Old methods are still available and give deprecation warnings. Please test Number 2, too. But it seems to work in the first test.
Jean-Philippe Lang wrote in #13460-7 (note-7):
I've committed the translations in r11654 but I think it's a bit late to change the methods for 2.3.0.
#1 Updated by Mischa The Evil over 7 years ago
The affected methods are
Daniel Felix wrote in #13460-8 (note-8):
Pretty much I think, though some of the deprecation warnings used in the patch are not correct:
Hopefully the way I use to deprecate those methods is good enough for the implementation. :-)
- the warning for
"My#reset_rss_key is deprecated and will be removed in Redmine 3.0. Please use #reset_atom_key instead."this should be
"MyController#reset_rss_key is deprecated and will be removed in Redmine 3.0. Please use MyController#reset_atom_key instead."
- the warning for
"User.rss_key is deprecated and will be removed in Redmine 3.0. Please use User.atom_key instead."this should be
"User#rss_key is deprecated and will be removed in Redmine 3.0. Please use User#atom_key instead."
reset_rss_keyis an instance method of
Myis an existing model in the Redmine core, which isn't), whereas the change you've made is in the
reset_rss_keyinstance method of
- I think it is better to include the class name when redirecting (in text obviously :) the user to the new, replacing method
User.rss_keyrefers to a class method in the
Userclass, while in the Redmine core
rss_keyis an instance method in the