Redmine

The affected methods are MyController#reset_rss_key, User#rss_key and User.find_by_rss_key.

Daniel Felix wrote in #13460-8 (note-8):

Hopefully the way I use to deprecate those methods is good enough for the implementation. :-)

1. the warning for MyController#reset_rss_key reads:
   

   "My#reset_rss_key is deprecated and will be removed in Redmine 3.0. Please use #reset_atom_key instead."

   this should be
   

   "MyController#reset_rss_key is deprecated and will be removed in Redmine 3.0. Please use MyController#reset_atom_key instead."

2. the warning for User#rss_key reads:
   

   "User.rss_key is deprecated and will be removed in Redmine 3.0. Please use User.atom_key instead."

   this should be
   

   "User#rss_key is deprecated and will be removed in Redmine 3.0. Please use User#atom_key instead."

• My#reset_rss_key says that reset_rss_key is an instance method of My (suggesting that My is an existing model in the Redmine core, which isn't), whereas the change you've made is in the reset_rss_key instance method of MyController
• I think it is better to include the class name when redirecting (in text obviously :) the user to the new, replacing method

• User.rss_key refers to a class method in the User class, while in the Redmine core rss_key is an instance method in the User class

Mischa The Evil wrote:

Shall we finally properly deprecate this in 5.0.0 and remove it in subsequent minor 5.x.x release (e.g. 5.1.0 or 5.2.0)?

I agree.

Go, do you need a new, rebased patch file or do you prefer to do the search and replace and the addition of the deprecation messages (modified according to my comments in note#1) locally yourself?