Patch #15118
Deprecate and rename rss_* methods to atom_* methods
Status: | New | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | - | % Done: | 0% | |
Category: | Code cleanup/refactoring | |||
Target version: | Candidate for next major release |
Description
This issue is extracted from #13460-2 after 2.4 feature freeze.
Relevant history:
Daniel Felix wrote in #13460-2 (note-2):
- File Attachment:functional_renaming_rss_to_atom.diff added
I'll provide two patches.
[...]
Number 2: functional renaming. Deprecation of old rss_* methods and redefining them as atom_* methods. Old methods are still available and give deprecation warnings. Please test Number 2, too. But it seems to work in the first test.Jean-Philippe Lang wrote in #13460-7 (note-7):
I've committed the translations in r11654 but I think it's a bit late to change the methods for 2.3.0.
Related issues
History
#1
Updated by Mischa The Evil over 7 years ago
The affected methods are MyController#reset_rss_key
, User#rss_key
and User.find_by_rss_key
.
Daniel Felix wrote in #13460-8 (note-8):
Pretty much I think, though some of the deprecation warnings used in the patch are not correct:Hopefully the way I use to deprecate those methods is good enough for the implementation. :-)
- the warning for
MyController#reset_rss_key
reads:"My#reset_rss_key is deprecated and will be removed in Redmine 3.0. Please use #reset_atom_key instead."
this should be"MyController#reset_rss_key is deprecated and will be removed in Redmine 3.0. Please use MyController#reset_atom_key instead."
- the warning for
User#rss_key
reads:"User.rss_key is deprecated and will be removed in Redmine 3.0. Please use User.atom_key instead."
this should be"User#rss_key is deprecated and will be removed in Redmine 3.0. Please use User#atom_key instead."
My#reset_rss_key
says thatreset_rss_key
is an instance method ofMy
(suggesting thatMy
is an existing model in the Redmine core, which isn't), whereas the change you've made is in thereset_rss_key
instance method ofMyController
- I think it is better to include the class name when redirecting (in text obviously :) the user to the new, replacing method
User.rss_key
refers to a class method in theUser
class, while in the Redmine corerss_key
is an instance method in theUser
class
#2
Updated by Mischa The Evil over 7 years ago
- Related to Patch #13460: All translations: RSS -> Atom added