Patch #16190
closed
Relax rejections based on Auto-Submitted header
Added by Felix Schäfer over 10 years ago.
Updated almost 10 years ago.
Description
One of our (Plan.io) uses an email server to forward messages to a Redmine instance which inserts Auto-Submitted: auto-forwarded
headers to the forwarded emails. Those emails are then rejected because of source:/trunk/app/models/mail_handler.rb@12937#L69.
Putting the fact aside that this header is only part of an IETF draft and not of an RFC, and that even according to that draft it shouldn't be there, this header causes the forwarded emails to be reject. We propose changing the Regex to only match the undesirable values defined in RFC3834, i.e. /^auto-(replied|generated)/
.
Files
To cite from RFC 3834
Recipients of messages containing an Auto-Submitted field with any keyword other than "no" MAY assume that the message was not manually submitted by a human.
Thus, although it may be correct to swallow this email, it makes it much harder for people using kind-of-broken mail servers (like Lotus Domino) which forcefully include the Auto-Submitted: auto-forwarded
header into all outgoing mails touched by their forwarding script.
In addition, given that forwarded mails generally are assumed to be valid, we could thus argue that the auto-forwarded
mails are not to be dropped.
Patch verified (and it's trivial anyway), can someone please merge this?
IMHO it's important that we merge such trivial patches right away and not let the contributor wait too long...
Jan Niggemann (redmine.org team member) wrote:
Patch verified (and it's trivial anyway), can someone please merge this?
IMHO it's important that we merge such trivial patches right away and not let the contributor wait too long...
I tried the patch in redmine-2.4.5 and worked fine. i'm using Lotus Domino and now the messages are not rejected.
- Target version set to 2.6.0
- Related to Feature #11338: Exclude emails with auto-submitted => auto-generated added
- Status changed from New to Closed
- Related to Defect #20465: MailHandler: ignoring email with Auto-Submitted:auto-generated header added
Also available in: Atom
PDF