Defect #17151
closed
File upload broken on Chrome 36
Added by Toshi MARUYAMA over 10 years ago. Updated over 10 years ago.
0%
Description
On Fedora 20:
https://www.google.com/intl/en/chrome/browser/beta.html
$ LANG=C rpm -qi google-chrome-beta-36.0.1985.49-1.x86_64 Name : google-chrome-beta Version : 36.0.1985.49 Release : 1 Architecture: x86_64 Install Date: Wed Jun 11 13:27:12 2014 Group : Applications/Internet Size : 182695355 License : Multiple, see http://chrome.google.com/ Signature : DSA/SHA1, Wed Jun 4 10:07:36 2014, Key ID a040830f7fac5991 Source RPM : google-chrome-beta-36.0.1985.49-1.src.rpm Build Date : Wed Jun 4 09:59:53 2014 Build Host : precise64build1.chrome.corp.google.com Relocations : /opt Packager : Chrome Linux Team <chromium-dev at chromium.org> Vendor : Google Inc. URL : http://chrome.google.com/ Summary : Google Chrome Description : The web browser from Google Google Chrome is a browser that combines a minimal design with sophisticated technology to make the web faster, safer, and easier.
When "Choose Files" is clicked:
Files
| fedora20-chrome-36.png (44.1 KB) fedora20-chrome-36.png | Toshi MARUYAMA, 2014-06-11 06:41 | ||
| 17151.patch (1.36 KB) 17151.patch | Felix Schäfer, 2014-06-25 14:11 | ||
| 17151_redmine_2.3_latest.patch (960 Bytes) 17151_redmine_2.3_latest.patch | Pierre Pretorius, 2014-07-23 13:45 |
Related issues
Updated by Etienne Massip over 10 years ago
It's a beta, are you sure it's not a browser issue ?
Updated by Toshi MARUYAMA over 10 years ago
Etienne Massip wrote:
It's a beta,
Yes.
But "37.0.2042.0 canary" has same problem.
http://www.chromium.org/getting-involved/download-chromium
No problem with following browser on my Windows 8.1are you sure it's not a browser issue ?
- Firefox 29.0.1
- Chrome 35.0.1916.153 m
- IE 11.0.9699.17107
Updated by Toshi MARUYAMA over 10 years ago
- Related to Defect #13932: File upload does not work with Safari added
Updated by Felix Schäfer over 10 years ago
I can confirm this bug on 38.0.2066.5 canary too, and a Planio customer observed this issue on Chrome 36.0.1985.84 too.
I think this is a browser issue though as both browsers make 2 requests to upload.js with 2 different attachment_id (1 and 2 in my and the customers tests).
Updated by Felix Schäfer over 10 years ago
- File 17151.patch 17151.patch added
Please find attached the proposed patch from one of my colleagues at Planio. This fixes the issue for us in Chrome 38.
It seems in Chrome 36 and following $(inputEl).clone().val(''); (source:trunk/public/javascripts/attachments.js@13182#L118) triggers the onchange callback a second time, adding the callback later instead of inline with the element solves this issue.
Updated by Jan from Planio www.plan.io over 10 years ago
- Status changed from New to Resolved
- Target version set to Candidate for next minor release
Updated by Toshi MARUYAMA over 10 years ago
- Status changed from Resolved to New
- Target version changed from Candidate for next minor release to 2.5.2
Updated by Toshi MARUYAMA over 10 years ago
- Target version changed from 2.5.2 to 2.4.6
Updated by Toshi MARUYAMA over 10 years ago
I have confirmed this patch fixes in google-chrome-beta-36.0.1985.84-1 on Fedora 20.
Updated by Toshi MARUYAMA over 10 years ago
- Subject changed from FIle upload broken on Chrome 36 to File upload broken on Chrome 36
Updated by Etienne Massip over 10 years ago
If this is a beta browser version issue, then why not fix browser instead??
Updated by Felix Schäfer over 10 years ago
The issue is indeed in the js code, but as it is somewhat of a corner case it didn't create a problem until now.
Furthermore, following this logic you would need to remove all IE or other browser-specific hacks :-)
Updated by Etienne Massip over 10 years ago
Felix Schäfer wrote:
Furthermore, following this logic you would need to remove all IE or other browser-specific hacks :-)
You don't get it, this fix is for a beta version, this is nonsense if the bug is indeed in the browser and not in jq or ror.
Could we wait for the 36 release to make sure it affects it too before committing it, eventually report the issue to chrome project?
Updated by Toshi MARUYAMA over 10 years ago
Etienne Massip wrote:
If this is a beta browser version issue, then why not fix browser instead??
Chrome 36, 37 and 38 have this problem.
Chrome and Chromium version policy is not clear.
I am afraid Chrome and Chromium team will refuse bug fix of Chrome 36.
Such as Rails team refused bug fix of Rails 3.2.
Updated by Etienne Massip over 10 years ago
What if it has already been fixed in 36 release?
Updated by Toshi MARUYAMA over 10 years ago
Such as Rails team refused bug fix of Rails 3.2.
Updated by Toshi MARUYAMA over 10 years ago
I have created chromium ticket.
http://goo.gl/FjMZtS
Updated by Toshi MARUYAMA over 10 years ago
- Target version set to 2.4.6
It may be too late for Google Chrome 36.
Updated by Toshi MARUYAMA over 10 years ago
- Has duplicate Defect #17366: Add duplicate files on chrome on Windows7 64bit added
Updated by Etienne Massip over 10 years ago
Chrome 36 is out and the regression hasn't been merged so it's buggy til 37 comes.
That would be great to add a comment to explain that this commit is due to regression and can be reverted when 37 is out.
Updated by Toshi MARUYAMA over 10 years ago
- Related to Defect #17495: Problem attaching files using Chrome ver. 36.0.1985.125 m and Button "Select files" added
Updated by Toshi MARUYAMA over 10 years ago
- Related to deleted (Defect #17495: Problem attaching files using Chrome ver. 36.0.1985.125 m and Button "Select files")
Updated by Toshi MARUYAMA over 10 years ago
- Has duplicate Defect #17495: Problem attaching files using Chrome ver. 36.0.1985.125 m and Button "Select files" added
Updated by Rafał Lisowski over 10 years ago
Updated by Gennady Grechin over 10 years ago
Rafał Lisowski wrote:
Redmine: 2.5.1.stable
Google Chrome: 36.0.1985.125
Not works for me.
Updated by Etienne Massip over 10 years ago
- Has duplicate Defect #17533: Attach File Broken in Chrome added
Updated by Etienne Massip over 10 years ago
- Has duplicate Defect #17528: AJAX uploading shows multiple uploads and inputs added
Updated by Pierre Pretorius over 10 years ago
The patch for 2.4 and 2.5 doesn't work in 2.3. Attached is the patch for 2.3. It modifies attachments.js to remove the onchange before cloning the input box, then it adds it to the cloned box afterwards.
Updated by Etienne Massip over 10 years ago
- Has duplicate Defect #17536: File attachment bug in the new version of chrome. added
Updated by Attila Radulovic over 10 years ago
Pierre Pretorius wrote:
The patch for 2.4 and 2.5 doesn't work in 2.3. Attached is the patch for 2.3. It modifies attachments.js to remove the onchange before cloning the input box, then it adds it to the cloned box afterwards.
Thank you very much Pierre, your patch file for 2.3 solved the problem within my 2.3.4.stable.12746.
Updated by Toshi MARUYAMA over 10 years ago
- Has duplicate Defect #17559: Same file gets Attach at atime with 21 FileUpload fields and other 8 uploading status on waiting. added
Updated by Cheyenne Wills over 10 years ago
Quick question.. on the 2.3 patch, does views/attachements/_form.html.erb need updated as well or just the javescript part?
Updated by Attila Radulovic over 10 years ago
Cheyenne Wills wrote:
Quick question.. on the 2.3 patch, does views/attachements/_form.html.erb need updated as well or just the javescript part?
I patched only the javascipt file with the command:
patch attachments.js < 17151_redmine_2.3_latest.patch
Updated by Vinicius Ferreira over 10 years ago
I'm running Redmine 2.5.1 and started having that problem with the latest Chrome update, version 36.0.1985.125 m. Is it fixed in 2.5.2? Is there a patch for 2.5.1?
Updated by Toshi MARUYAMA over 10 years ago
Updated by red dot over 10 years ago
I'm also running Redmine 2.5.1 is there any patch for it? Or can I use the attachments.js and _form.html.erb from 2.5.2 in 2.5.1 to fix this bug?
Updated by Toshi MARUYAMA over 10 years ago
red dot wrote:
I'm also running Redmine 2.5.1 is there any patch for it?
http://www.redmine.org/projects/redmine/repository/revisions/13201/diff?format=diff
Updated by Toshi MARUYAMA over 10 years ago
- Has duplicate Defect #17606: Reproduction of forms to add files in the browser Google Chrome! added
Updated by Fernando Silva over 10 years ago
Hi guys, firstly, thank you by your effort on fixing it!
I'm using a BitNami package - 2.5.2 and I've just migrate from 2.4.1 and I would like to share with you guys that I had to run the following commands on MySQL, in order to run 2.5.2 correctly (it was need due my customized fields ;)
use bitnami_redmine ALTER TABLE custom_fields ADD format_store TEXT(65535); ALTER TABLE custom_fields ADD description TEXT(65535);
Tks again!
Fernando Sampaio
Updated by seyfer seed over 10 years ago
Toshi MARUYAMA wrote:
red dot wrote:
I'm also running Redmine 2.5.1 is there any patch for it?
http://www.redmine.org/projects/redmine/repository/revisions/13201/diff?format=diff
How to use it? - solved
I'm use it, and it's not solve my problem.
I have same ussue like in top screen on 2.5.1.
Updated by Toshi MARUYAMA over 10 years ago
seyfer seed wrote:
Toshi MARUYAMA wrote:
red dot wrote:
I'm also running Redmine 2.5.1 is there any patch for it?
http://www.redmine.org/projects/redmine/repository/revisions/13201/diff?format=diff
How to use it? - solved
I'm use it, and it's not solve my problem.
I have same ussue like in top screen on 2.5.1.
Why not update to 2.5.2?
Updated by Toshi MARUYAMA over 10 years ago
- Has duplicate Defect #17653: Layout is broken when using chrome to upload an attachment added
Updated by Toshi MARUYAMA over 10 years ago
seyfer seed wrote:
Toshi MARUYAMA wrote:
red dot wrote:
I'm also running Redmine 2.5.1 is there any patch for it?
http://www.redmine.org/projects/redmine/repository/revisions/13201/diff?format=diff
How to use it? - solved
How do you apply?
Updated by Toshi MARUYAMA over 10 years ago
chu chu wrote:
Hi, I still encounter the same problem in 2.5.2.stable.
How do you check your version is 2.5.2?
Updated by Toshi MARUYAMA over 10 years ago
- Has duplicate Defect #17665: Attachment upload called twice using Chrome added
Updated by Toshi MARUYAMA over 10 years ago
- Has duplicate Defect #17677: When upload file, program show multi control upload and duplication current file upload added
Updated by Toshi MARUYAMA over 10 years ago
This issue should be fixed by 36.0.1985.143, which was pushed to stable channel yesterday.
Updated by chu chu over 10 years ago
Toshi MARUYAMA wrote:
This issue should be fixed by 36.0.1985.143, which was pushed to stable channel yesterday.
It works well now,
thank you!