Redmine

Your first request is a duplicate of #515

Is this implemented?

I'm wondering why one does not get an notification if he or she gets added to the watchers list. Shouldn't this be normal? Now, if I add an user to the list, I have to send them a mail 'manually' to let him or her know 'Look at this issue. Please, have a look at it/Please, post something.'

Is there a certain reason why there is no automatic notification? Or is it just not implemented yet?

Note: #10357 also proposes to send an email to the watcher when they are removed from the list.

+1

+1

+1

+1

+1

User Redmine wrote in #note-13:

Suggest some patch. The patch was collected in file partly manually and it's better to copy-paste new code to your sources (but not auto apply).
What the patch does:

• the notification is sent to the user when he has been added to watchers or removed from watchers.
• the notification consists name of person who added/deleted the watcher.
• the notification could be disabled/enebled by setting in Redmine issue_updated

Hi! Thanks for the contribution, I tried it with Redmine 5.1.1.stable but it didnt work, I'm getting this error:

@uri=#<URI::GID gid://redmine-app/Issue/21627>>, #<GlobalID:0x00007fe775ffde08 @uri=#<URI::GID gid://redmine-app/User/19>>]}
E, [2024-04-30T15:13:15.435997 #2024246] ERROR -- : [ActiveJob] [ActionMailer::MailDeliveryJob] [e76309d4-8049-47ba-98c0-f6e06a875cbb] Error performing ActionMailer::MailDeliveryJob (Job ID: e76309d4-8049-47ba-98c0-f6e06a875cbb) from Async(mailers) in 56.87ms: NameError (uninitialized constant Mailer::Text

    @table = Text::Table.new
             ^^^^):
/opt/www/**/htdocs/app/models/mailer.rb:193:in `issue_watcher_delete'

Another question. In Adminstration => Setting => Notification, should there be a new checkbox or is it depending on the existing "update ticket" checkbox?

Hi! Thanks for the contribution, I tried it with Redmine 5.1.1.stable but it didnt work, I'm getting this error:

The patch tested on Redmine 4.2.7.stable.

The error appears due to a gem that is not installed on your Redmine. To solve it, you can do only ONE of the following:
- Add to your file "Gemfile" in source folder a line: gem 'text-table' and restart your redmine
or
- From patch delete all lines with @table = Text::Table.new
One thing should help.

Another question. In Adminstration => Setting => Notification, should there be a new checkbox or is it depending on the existing "update ticket" checkbox?

No new checkbox.
Only works when "Issue updated" is checkboxed in Adminstration => Setting => Email notifications.

thx again, I tried the 2nd option and removed the two lines. Now we got a different Error

, [2024-05-03T16:42:41.269799 #2228711] ERROR -- : [ActiveJob] [ActionMailer::MailDeliveryJob] [820c0bdd-7e0f-4824-9fa7-c98adbbafd6d] Error performing ActionMailer::MailDeliveryJob (Job ID: 820c0bdd-7e0f-4824-9fa7-c98adbbafd6d) from Async(mailers) in 36.24ms: NoMethodError (undefined method `mail_signature_for' for #<Mailer:0x00000000031880>

@mail_signature = mail_signature_for(user, issue)
^^{^^}^^^^^^^^^^^^^
Did you mean? mail_handler_url):

Yes, indeed, this part of code is also non-default.
You need to delete from patch all lines with @mail_signature = mail_signature_for(user, issue)
This should be the last compatibility problem with your redmine sources.

Yes, I can confirm that this worked now. Mails are sent, thanks for your work.

Robert Röttger wrote in #note-20:

Yes, I can confirm that this worked now. Mails are sent, thanks for your work.

Can you please attach version for 5.1.1?

I removed lines, described in thread but i get this:

Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/app/controllers/watchers_controller.rb b/app/controllers/watchers_controller.rb
|index ba13e0e0..d28ac90a 100644
|--- a/app/controllers/watchers_controller.rb
|+++ b/app/controllers/watchers_controller.rb
--------------------------
File to patch: ^C
root@redmine5:/opt/redmine# patch -p0 < notify_watcher_when_add_or_delete_in_issue.patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/app/controllers/watchers_controller.rb b/app/controllers/watchers_controller.rb
|index ba13e0e0..d28ac90a 100644
|--- a/app/controllers/watchers_controller.rb
|+++ b/app/controllers/watchers_controller.rb
--------------------------
File to patch: app/controllers/watchers_controller.rb
patching file app/controllers/watchers_controller.rb
patch: **** malformed patch at line 19: @@ -71,10 +81,19 @@ class WatchersController < ApplicationController

Hi,

i used the patch from comment 13 and removed all lines containing "@mail_signature = mail_signature_for(user, issue)" and "@table = Text::Table.new"
Then I applied the patch manually using copy & paste . I have not applied it automattically running patch function.