Project

General

Profile

Actions
Copy link

Patch #18290

closed

Issue performance patch

Added by Ondřej Ezr over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Code cleanup/refactoring
Target version:
3.0.0

Description

Issue safe_attribute 'is_private' cause a author loading if not necessary in some situations, and status_id_was is same as status_id, and it is not preventing loading if not changed.

Please accept, I hate patch all method, cuz one line change :(

Files

issue_performance.diff (1.17 KB) issue_performance.diff Ondřej Ezr, 2014-11-06 10:16

Related issues

Has duplicate Redmine - Patch #17880: Performance issues on Issue modelClosedActions
Actions
Copy link
 #1

Updated by Mischa The Evil over 11 years ago

  • Category set to Code cleanup/refactoring
Actions
Copy link
 #2

Updated by Jean-Philippe Lang over 11 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version set to 3.0.0

The author load fix is committed in r13576.

The second part is not OK and breaks a bunch of tests because #status_was would return nil if status was not changed, where it should return the current status. Fixed in r13577.

The last part is no longer in sync with trunk.

Thanks for your submission.

Actions
Copy link
 #3

Updated by Go MAEDA over 10 years ago

  • Has duplicate Patch #17880: Performance issues on Issue model added
Actions
Copy link

Also available in: Atom PDF