Feature #18555
Show warning when attempting to attach more than the allowed number of attachments
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | Attachments | |||
| Target version: | 4.2.0 | |||
| Resolution: | Fixed |
Description
I was just notified by an employee of mine that my ticket was missing some of the attached files that should have been there. I thought I had merely forgot to attach them; however, upon repeating my edit due to needing to remake all the files I learned that redmine has a hard limit of 10 files attached per edit.
Although I'm not sure why this limit exists (I'll be adding another issue to make this a setting or remove it) redmine should definitely alert the end user to the limit both beforehand such as like the the text for max file size is displayed as well as after an attempt to add more than 10 files is added (javascript alert box or something similar).
This is related to issue #8579
This is the code in question: source:/trunk/public/javascripts/attachments.js#L6
remine number of files limit beforehand.png (229 KB)
defect-18555-v1.patch 
(1.97 KB)
ScreenShot.png (200 KB)
defect-18555-v2.patch
(2.04 KB)
defect-18555-v3.patch
(2.08 KB)
alerts-appear-multiple-times.gif (507 KB)
fix-the-number-of-alerts.patch
(1.21 KB)
Related issues
Associated revisions
Show warning when attempting to attach more than the allowed number of attachments (#18555).
Patch by Mizuki ISHIKAWA.
Update locales (#18555).
Fix that alerts may be displayed multiple times when the number of files attempting to be uploaded exceeds the limit (#18555).
Patch by Mizuki ISHIKAWA.
History
#1
Updated by Go MAEDA over 7 years ago
- Related to Feature #18556: Add ability to configure limit of attachments at once added
#2
Updated by Go MAEDA over 7 years ago
- Duplicated by Defect #18642: Limited number of simultanous file uploads added
#3
Updated by Mizuki ISHIKAWA about 2 years ago
- File defect-18555-v1.patch added
- File ScreenShot.png added
After adding the eleventh file, I attached a patch that gives a javascript alert like the image below.
max-number-of-files-message:
This file cannot be uploaded because the maximum number of files that can be attached at the same time has been reached.
I'm not a native English speaker, so I'd like someone to review the "max-number-of-files-message".
#4
Updated by Mizuki ISHIKAWA about 2 years ago
- File defect-18555-v2.patch added
I changed the message.
#5
Updated by Go MAEDA about 2 years ago
- Target version set to Candidate for next major release
#6
Updated by Mizuki ISHIKAWA about 2 years ago
- File defect-18555-v3.patch added
@Marius BALTEANU and @Bernhard Rohloff corrected the English sentence, so I updated the patch based on that.
#7
Updated by Go MAEDA about 2 years ago
- Target version changed from Candidate for next major release to 4.2.0
Setting the target version to 4.2.0.
#8
Updated by Go MAEDA about 2 years ago
- Tracker changed from Defect to Feature
- Subject changed from Notify user when attempting to attach more than the allowed number of attachments to Show warning when attempting to attach more than the allowed number of attachments
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you for improving Redmine.
#9
Updated by Go MAEDA about 2 years ago
- Status changed from New to Closed
#10
Updated by Mizuki ISHIKAWA over 1 year ago
- File alerts-appear-multiple-times.gif added
- File fix-the-number-of-alerts.patch added
With this change, you will now be alerted three times when you attach 13 files at the same time. The alert will be repeated as many times as the limit of 10 is exceeded. ( Related comment: https://www.redmine.org/issues/30776#note-7 )
I think one alerts is enough, so I'll attach a patch to fix it.
#11
Updated by Go MAEDA over 1 year ago
- Status changed from Closed to Reopened
#12
Updated by Go MAEDA over 1 year ago
- Status changed from Reopened to Closed
Mizuki ISHIKAWA wrote:
With this change, you will now be alerted three times when you attach 13 files at the same time. The alert will be repeated as many times as the limit of 10 is exceeded. ( Related comment: https://www.redmine.org/issues/30776#note-7 )
Fixed in r20711. Thank you.