Actions
Patch #18911
closed
check Setting.protocol when determining gravatar protocol
Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Project settings
Target version:
-
Start date:
Due date:
% Done:
0%
Estimated time:
Description
proposed change is in line 1235 of app/helpers/application_helper.rb
instead:
options.merge!({:ssl => (request && request.ssl?), :default => Setting.gravatar_default})
change to:
options.merge!({:ssl => ((Setting.protocol == 'https') || (request && request.ssl?)), :default => Setting.gravatar_default})
without that when Redmine is behind reverse proxy that do SSL gravatar links are generated as http (when everywhere else is https as expected after Setting.protocol is changed to 'https')
Related issues
Updated by Toshi MARUYAMA about 10 years ago
- Related to Defect #9365: Gravatar don't utilize HTTPS added
Updated by
Updated by Go MAEDA about 9 years ago
- Related to Defect #21855: Gravatar get images over http instead https added
Actions