Redmine

Hi, this bug is still present, but you can reproduce it only if you use non-redmine custom text formatter which supports html (like ckeditor, markdown/textile formatter escape brackets, so <a> will be &\lt;a&\gt; and the affected regex will not fail).
To avoid that I need to patch this method and gsub! these occurances, which causes unnecessary overhead. Or I can patch the whole method (~140 lines!!! definetely worth to refactor) only because of one character.

Can someone take a look at it again? Patch, test-case and backtrace are already attached.

Pavel Rosický wrote:

Hi, this bug is still present, but you can reproduce it only if you use non-redmine custom text formatter which supports html (like ckeditor, markdown/textile formatter escape brackets, so <a> will be <a> and the affected regex will not fail).

Could you add test cases for it?

Toshi MARUYAMA wrote:

Could you add test cases for it?

I already did, 7 months ago.

Test case - http://www.redmine.org/attachments/13295/application_helper_test.rb.patch :

def test_should_handle_a_tag_without_attributes
  text = '<a>http://example.com</a>'
  assert_nil parse_redmine_links(text, nil, nil, nil, true, {})
end

Without patch:
1) Error:
ApplicationHelperTest#test_should_handle_a_tag_without_attributes:
NoMethodError: undefined method `+' for nil:NilClass
app/helpers/application_helper.rb:873:in `block in parse_redmine_links'
app/helpers/application_helper.rb:742:in `gsub!'
app/helpers/application_helper.rb:742:in `parse_redmine_links'
test/unit/helpers/application_helper_test.rb:1262:in `test_should_handle_a_t
ag_without_attributes'
94 runs, 379 assertions, 0 failures, 1 errors, 0 skips

With patch - http://www.redmine.org/attachments/13280/application_helper.rb.patch :
94 runs, 380 assertions, 0 failures, 0 errors, 0 skips

What else can I do?
If you want to test textilizable(), I'll have to include ckeditor and a custom html formatter (plugin). Such tests can't be included in a standard Redmine's test suite.

Pavel Rosický wrote:

If you want to test textilizable(), I'll have to include ckeditor and a custom html formatter (plugin).

Could you add dummy formatter?